Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Streaming end is not fully OpenAI compatible. [DONE\n] message missing newline #297

Open
AlexanderZhk opened this issue Oct 14, 2024 · 0 comments

Comments

@AlexanderZhk
Copy link

Noticed this behaviour in the CodeGPT plugin (https://github.com/appleboy/CodeGPT) when using with pipelines:
image

The issue is that the openai implementation "newlines" the final bracket ("]") in the [DONE\n] message.
Like this:
image

However, in the pipelines implementation, the [DONE\n] message does not have the newline character:

yield f"data: [DONE]"

Changing this line to yield f"data: [DONE\n]" would increase the openai compatibility of Pipelines.

Tested with the CodeGPT plugin - works correctly with this change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant