Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minimize memory use for un-sampled spans #1117

Open
MrAlias opened this issue Sep 20, 2024 · 0 comments
Open

Minimize memory use for un-sampled spans #1117

MrAlias opened this issue Sep 20, 2024 · 0 comments

Comments

@MrAlias
Copy link
Contributor

MrAlias commented Sep 20, 2024

If we call start_tracking_span it should make sure the context is propagated. That means we need to call stop_tracking_span when the span in ended. However, we use the active_spans_by_span_ptr to fetch the span in the end probe so not updating the map means we won't be able to fetch the span in the return probe, and won't clean the span context maps properly.

I'd prefer to save maps space for un-sampled spans but it seems more tricky than I initially thought.

Originally posted by @RonFed in #1107 (comment)

@MrAlias MrAlias mentioned this issue Sep 20, 2024
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant