Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config: Top-level functions #6602

Open
pellared opened this issue Jan 13, 2025 · 2 comments
Open

config: Top-level functions #6602

pellared opened this issue Jan 13, 2025 · 2 comments
Labels
area: config Related to config functionality enhancement New feature or request

Comments

@pellared
Copy link
Member

pellared commented Jan 13, 2025

Currently there are two config packages:

  • go.opentelemetry.io/contrib/config/v0.2.0
  • go.opentelemetry.io/contrib/config/v0.3.0

The user should be able to have functions like LoadYAML in go.opentelemetry.io/contrib/config which gives the possibility to setup the OTel Go SDK without knowing what is the exactly file-version in the OTel config file.

Maybe go.opentelemetry.io/contrib/config/v[X.Y.Z] should be even internal?

Related to:

@pellared pellared added enhancement New feature or request area: config Related to config functionality labels Jan 13, 2025
@pellared pellared changed the title config: Top-level function config: Top-level functions Jan 13, 2025
@pellared
Copy link
Member Author

pellared commented Jan 13, 2025

Or maybe we should just support the latest version? Alternativly we could leave as it is until v1.0 of file-version.

@MrAlias
Copy link
Contributor

MrAlias commented Jan 13, 2025

I think the original motivation was to help in migration when there are breaking changes: #6412

I'm not sure we can accomplish that without these separate packages.

It might also not make sense to merge after 1.0 if the config stability guarantees do not guarantee the rendered config's stability: open-telemetry/opentelemetry-configuration#89

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: config Related to config functionality enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants