Conftest doesn't exit with plugin exit code

[iAlexBLR]

Issue:

I've created a conftest plugin for some custom behaviour, but I noticed that conftest when uses installed plugin always returns 0 exit code even if plugin itself returns another one.

Reproduce steps:

script.sh

#!/usr/bin/env bash
set -e
exit 1

plugin.yaml

name: script
version: 0.1.0
usage: conftest script
command: ./script.sh

Testing:

% ./script.sh
% echo $?
1
%
% conftest plugin install .
% conftest script
% echo $?
0

[jalseth]

Thanks for raising this. If you have the time, I'd welcome a PR to fix.

[iAlexBLR]

@jalseth unfortunately I'm not that good at programming on Go

[jpreese]

@iAlexBLR this is sort of by design, see: https://www.conftest.dev/plugins/ (at the bottom)

It has been a long time since I've dealt with plugins in Conftest, but do recall plugins needing to specify other error codes. I can see how this can be confusing though, and I don't recall the technical reason for it unfortunately.