Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review requirement IDs used in tests #204

Open
beeme1mr opened this issue Jan 23, 2024 · 3 comments
Open

Review requirement IDs used in tests #204

beeme1mr opened this issue Jan 23, 2024 · 3 comments
Labels
enhancement New feature or request help wanted Extra attention is needed test Improvement or additions to test suite

Comments

@beeme1mr
Copy link
Member

beeme1mr commented Jan 23, 2024

Requirements

The requirement IDs used in the specification changed when we added support for client-side feature flags. The .NET SDK uses those IDs in some tests. These should be reviewed to make sure they match the spec.

Requirements that are out of date:

  • dotnet-sdk/test/OpenFeature.Tests/OpenFeatureClientTests.cs
    • Spec IDs: 1.4.5-1.4.14
  • dotnet-sdk/test/OpenFeature.Tests/OpenFeatureHookTests.cs
    • Spec IDs: 4.3.3-4.3.8

Here's the diff between spec v0.5.2 and v0.8.0.

@beeme1mr beeme1mr added enhancement New feature or request help wanted Extra attention is needed test Improvement or additions to test suite labels Jan 23, 2024
@beeme1mr beeme1mr added this to the spec v0.7.0 milestone Jan 23, 2024
@roelofb
Copy link
Contributor

roelofb commented Feb 4, 2024

The evaluation context also lacks the required 'targeting key` field

[Specification("3.1.1", "The `evaluation context` structure MUST define an optional `targeting key` field of type string, identifying the subject of the flag evaluation.")]

@toddbaert
Copy link
Member

@roelofb excellent catch! I've created a bug for this: #230

@roelofb
Copy link
Contributor

roelofb commented Feb 7, 2024

@toddbaert Added a PR: #231

@askpt askpt added the v0.7.0 spec v0.7.0 compliance label Feb 12, 2024
@toddbaert toddbaert removed the v0.7.0 spec v0.7.0 compliance label Mar 12, 2024
@toddbaert toddbaert modified the milestones: spec v0.7.0, Spec v0.8.0 Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed test Improvement or additions to test suite
Projects
None yet
Development

No branches or pull requests

4 participants