Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check schema field and codelist code descriptions against OCDS, ePO, UNCITRAL glossaries #827

Closed
jpmckinney opened this issue Mar 22, 2019 · 26 comments
Assignees
Labels
Codelist: Closed Relating to a closed codelist Semantics Relating to field and code descriptions
Milestone

Comments

@jpmckinney
Copy link
Member

jpmckinney commented Mar 22, 2019

Same as #826 but for OCDS 1.2 due to versioning policy.

@jpmckinney jpmckinney added Schema Relating to other changes in the JSON Schema (renamed fields, schema properties, etc.) Codelist: Closed Relating to a closed codelist labels Mar 22, 2019
@jpmckinney jpmckinney added this to the 1.2 milestone Mar 22, 2019
@jpmckinney jpmckinney changed the title Check schema field and closed codelist code descriptions against OCDS and ePO glossaries Check schema field and closed codelist code descriptions against OCDS, ePO, UNCITRAL glossaries Aug 9, 2019
@jpmckinney
Copy link
Member Author

Copying comment from #380 (comment):

UNCITRAL has a term matching the semantics of 'direct':

Single-source procurement: A method of procurement of last resort which main distinct feature is the absence of competition since the invitation to present a quotation or proposal is addressed only to one supplier or contractor.

@jpmckinney jpmckinney added Codelist: Semantics Semantics Relating to field and code descriptions and removed Schema Relating to other changes in the JSON Schema (renamed fields, schema properties, etc.) Codelist: Semantics labels Jul 17, 2020
@jpmckinney
Copy link
Member Author

@ColinMaudry
Copy link
Member

We could work toward having a taxonomy, connecting concepts according to various properties (equivalent to, similar to, related, broader, narrower), using the SKOS ontology (W3C recommendation) and publishing it using Skosmos(website, Github, example of taxonomy).

@ColinMaudry
Copy link
Member

@ColinMaudry
Copy link
Member

@jpmckinney Are the code lists available in tabular format?

@jpmckinney
Copy link
Member Author

@ColinMaudry I can prepare that. Do you want one sheet with all codelists, or one sheet per codelist?

@ColinMaudry
Copy link
Member

On sheet with all. Thanks!

@ColinMaudry
Copy link
Member

Four columns: codelist, code, code label, code description.

@jpmckinney
Copy link
Member Author

From the schema/codelists directory, in fish shell, I ran:

for i in *.csv; if test $i != 'currency.csv'; csvcut -c Code,Title,Description $i | csvstack -g (string replace .csv "" $i); end; end | sort > ../codelists.csv

Uploading the CSV as TXT: codelists.txt

@ColinMaudry
Copy link
Member

You don't use xsv yet ?! All the cool kids do 🤓

@jpmckinney
Copy link
Member Author

From #902: We might find other places where we want to replace "contract" with "contract, framework agreement or dynamic purchasing system".

@JachymHercher
Copy link
Contributor

From #902: We might find other places where we want to replace "contract" with "contract, framework agreement or dynamic purchasing system".

Is this a question of precision and/or "apparent audience"/readability? If just the former, then we might not need to change anything, assuming that #896 results in contracts covering also frameworks and dynamic purchasing systems. If also the latter, then essentially repeating parts of other definitions is something we should have a policy on (probably part of #850). My reflex would be not to do it, because it makes things longer and makes updates hard / impossible compared to a single source of truth approach.

@jpmckinney
Copy link
Member Author

Good point. I am happy with an approach that reduces repetition.

@ColinMaudry
Copy link
Member

ColinMaudry commented Nov 30, 2020

@jpmckinney @JachymHercher The glossary now includes OCDS schema terms and OCDS codes.

I have hidden the OCP terms that were not relevant for the addition in a glossary of procurement, usually because they are specific to OCDS (release, ocid, awardID, etc.).

I have matched the following sources with the remaining terms:

  • MAPS glossary
  • ePO glossary
  • UNCITRAL glossary
  • EBRD glossary

For each of these sources, I have tagged the terms as either (see column Relevant) in each source tab:

  • "Relevant" (the term would be a good entry in the OCP glossary)
  • or "Added" (the term matches an existing entry and has been added as such)
  • or nothing (the term isn't relevant for the glossary, usually because it's too specific, or not close enough to the scope of OCDS)

Many terms would be good additions to the glossary. I suggest that you have a look and that we call to discuss the next steps.

@ColinMaudry
Copy link
Member

I start adding eForms

@ColinMaudry
Copy link
Member

@JachymHercher Do you know where I can find the latest definitions for eForms BTs? I'm not sure I have the latest spreadsheet.

@jpmckinney
Copy link
Member Author

Awesome! Thanks for the update, @ColinMaudry. For eForms, see the annex linked from this page. There is another spreadsheet for codelists, but I can't find it quickly.

For a call, I'll send an email.

@JachymHercher
Copy link
Contributor

The codelists are at https://op.europa.eu/en/web/eu-vocabularies/e-procurement/tables (click codelist and then "browse content").

@ColinMaudry
Copy link
Member

ColinMaudry commented Dec 17, 2020

I have added the terms from eForms annex and matched them to OCDS fields or codes when relevant.

@ColinMaudry
Copy link
Member

I have added comments when an eForm term probably matches a field or code from an OCDS extension.

@jpmckinney
Copy link
Member Author

jpmckinney commented Jan 5, 2021

A mapping between eForms and the eProcurement Ontology is at https://github.com/eprocurementontology/eprocurementontology/blob/v2.0.2/v2.0.2/03-Analysis%20and%20design/eForms2ePO/Ontology_eForms_Mapping_New%20Regulation.xlsx (OP-TED/ePO#277)

I did a bit of tidying in https://docs.google.com/spreadsheets/d/1Pj4mMIPU-UosrA2rR6Ty7mXNLLOV9sfH/edit#gid=1167530975

It looks like 147 out of 284 BT/BGs have an ePO definition (which might not mention the ePO term). 57 have ePO working group comments (40 of which have no ePO definition).

@ColinMaudry
Copy link
Member

I have added most of eForms code in a new sheet from the eProcurement code tables.

I have skipped the following codelists:

  • Applicability codes (irrelevant)
  • CPV and CPVS (too big)
  • Change corrig justification (irrelevant)
  • Communication justification (irrelevant)
  • Country (irrelevant)
  • Currency (irrelevant)
  • Environmental impact (irrelevant)
  • Language (irrelevant)
  • NUTS (too big)
  • Permission (irrelevant)
  • Time period (irrelevant)
  • Usage (irrelevant)

@ColinMaudry
Copy link
Member

I have matched eForms codes with OCDS schema fields and OCDS codes.

@jpmckinney jpmckinney changed the title Check schema field and closed codelist code descriptions against OCDS, ePO, UNCITRAL glossaries Check schema field and codelist code descriptions against OCDS, ePO, UNCITRAL glossaries Jan 13, 2021
@jpmckinney
Copy link
Member Author

I've updated the glossary:

I won't review ePO and eForms as they are too long, so I'll trust that they are mapped correctly.

I consider the crosswalk complete. Once we've worked on the other semantic issues, we can review the remaining concepts to see if any definitions can be improved based on the crosswalk.

@ColinMaudry
Copy link
Member

Since many OCDS definitions have moved in the 1.2-dev branch, we should also update them in the glossary.

@jpmckinney
Copy link
Member Author

jpmckinney commented Nov 30, 2021

The glossary has been very useful in clarifying the main concepts. For the remaining, less "core" concepts, there is relatively low overlap across the different sources, and in some cases the source has a much narrower definition.

I think keeping the OCDS definitions up-to-date will be too tedious, but it is something we can do if/when necessary. After all, the main value of the crosswalk is to find the other sources' definitions, not OCDS'.

I have linked to the crosswalk from the schema style guide https://ocds-standard-development-handbook.readthedocs.io/en/latest/meta/schema_style_guide.html#field-and-code-descriptions

I think we covered all the key terms that are likely to change based on other sources' definitions (buyer, procuring entity, tender, award, contract, amendment, etc.).

If we notice a lack of clarity, we can open an issue about an individual field, and reference the crosswalk.

@jpmckinney jpmckinney moved this to Done in OCDS 1.2 Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Codelist: Closed Relating to a closed codelist Semantics Relating to field and code descriptions
Projects
Status: Done
Development

No branches or pull requests

3 participants