Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test JSON paths #55

Open
jpmckinney opened this issue Nov 23, 2021 · 0 comments
Open

Test JSON paths #55

jpmckinney opened this issue Nov 23, 2021 · 0 comments
Labels
Milestone

Comments

@jpmckinney
Copy link
Member

jpmckinney commented Nov 23, 2021

We should add a test to check that the argument to the get_values function is a valid OCDS JSON path. For example, in dataset/distribution/main_procurement_category.py, we'd test that tender.mainProcurementCategory is a JSON path that actually occurs in OCDS data.

https://ocdskit.readthedocs.io/en/latest/api/schema.html#ocdskit.schema.get_schema_fields can yield all JSON paths from the OCDS schema.

@jpmckinney jpmckinney added this to the Cleanup milestone Jan 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant