Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please consider to add progress indicator for time consuming command in the clusteradm #79

Open
kim-fitness opened this issue Dec 3, 2021 · 5 comments

Comments

@kim-fitness
Copy link
Member

So far, there are several time consuming command in the clusteradm,
E.g.
clusteradm join

During the command runs, there is no indicator to show the progress, which makes user confused that whether the command is running or it already die.

@kim-fitness kim-fitness changed the title Please consider to add progress bar for time consuming command in the clusteradm Please consider to add progress indicator for time consuming command in the clusteradm Dec 3, 2021
@kim-fitness
Copy link
Member Author

/label enhancement

@openshift-ci
Copy link

openshift-ci bot commented Dec 3, 2021

@kim-fitness: The label(s) /label enhancement cannot be applied. These labels are supported: platform/aws, platform/azure, platform/baremetal, platform/google, platform/libvirt, platform/openstack, ga, tide/merge-method-merge, tide/merge-method-rebase, tide/merge-method-squash, px-approved, docs-approved, qe-approved, downstream-change-needed, backport-risk-assessed, cherry-pick-approved

In response to this:

/label enhancement

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kim-fitness
Copy link
Member Author

This could be an enhancement

@xauthulei
Copy link
Member

@kim-fitness , Currently, there is a --wait option, it could display our internal process. Is that could meet your request, Thanks :

llhu@huleis-mbp clusteradm % bin/clusteradm join --hub-token XXXX --hub-apiserver https://127.0.0.1:62556 --wait --cluster-name llhu-1  --force-internal-endpoint-lookup  
CRD successfully registered.
⠸ Waiting for registration operator to become ready... (ContainerCreating)   <<<<<<<<<<<<<<<<

@kim-fitness
Copy link
Member Author

kim-fitness commented Mar 9, 2022

@kim-fitness , Currently, there is a --wait option, it could display our internal process. Is that could meet your request, Thanks :

llhu@huleis-mbp clusteradm % bin/clusteradm join --hub-token XXXX --hub-apiserver https://127.0.0.1:62556 --wait --cluster-name llhu-1  --force-internal-endpoint-lookup  
CRD successfully registered.
⠸ Waiting for registration operator to become ready... (ContainerCreating)   <<<<<<<<<<<<<<<<
  1. The --wait parameter means let the clusteradm to wait until the operation is finished. There is no guarantee that the command should print a spinner or something else to indicate the progress. This depends on the command implementation.
  2. Only a few commands has the --wait parameter, there are still many commands don't have it, for example, the unjoin command.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants