Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Extend Provider Implementations #18

Open
emhane opened this issue Jan 8, 2025 · 2 comments · May be fixed by #49
Open

[Feature] Extend Provider Implementations #18

emhane opened this issue Jan 8, 2025 · 2 comments · May be fixed by #49
Labels
A-provider Area: provider crate C-feat Category: new feature or request D-good-first-issue Desc: issues that are easy to pick up for new contributors

Comments

@emhane
Copy link
Member

emhane commented Jan 8, 2025

Component

provider

Describe the feature you would like

The alloy-provider crate has reqwest-backed implementations of the Provider trait, exposing provider implementations.

op-alloy-provider only provides an extension for the provider, but doesn't have implementations for traits in op-alloy.

This issue is to implement the BatchValidationProvider from the op-alloy-protocol crate in op-alloy-provider using the ReqwestProvider from alloy-provider. This can be hidden behind a feature flag if needed.

Exposing an implementation of the BatchValidationProvider using the ReqwestProvider allows downstream applications to easily plug in a ReqwestProvider for batch validation.

Additional context

No response

@emhane emhane added A-provider Area: provider crate C-feat Category: new feature or request D-good-first-issue Desc: issues that are easy to pick up for new contributors labels Jan 8, 2025
@sergerad sergerad linked a pull request Jan 13, 2025 that will close this issue
3 tasks
@sergerad
Copy link
Contributor

@emhane I've put a PR together if you wanted to weigh in an give more instructions on how to proceed. My understanding of your issue description was that the approach should be same/similar to how the impl <N, T, P> EngineApiExt<N,T> for P works in engine.rs.

Also my understanding is that those BatchValidatorProvider fns can use the traditional Eth JSON RPC endpoints, rather than any Optimism specific ones.

Thanks!

@emhane
Copy link
Member Author

emhane commented Jan 13, 2025

thanks @sergerad ! forwarding your message to @refcell (the original author of this issue)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-provider Area: provider crate C-feat Category: new feature or request D-good-first-issue Desc: issues that are easy to pick up for new contributors
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants