Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link to top level does not work after search #22

Open
pwalczysko opened this issue Aug 21, 2020 · 5 comments
Open

Link to top level does not work after search #22

pwalczysko opened this issue Aug 21, 2020 · 5 comments

Comments

@pwalczysko
Copy link
Member

pwalczysko commented Aug 21, 2020

It is a good feature to be able to click on the top-left-corner Docs link which brings you to https://omero-guides.readthedocs.io/en/latest/index.html

This feature works also when you are in a deeper level, such as https://omero-guides.readthedocs.io/en/latest/upload/docs/import-desktop-client.html

But if you navigate to such deeper level using Search, such as

cc @jburel @sbesson

@sbesson
Copy link
Member

sbesson commented Aug 21, 2020

Reading briefly, I think this is related to https://docs.readthedocs.io/en/stable/subprojects.html#search i.e. the search indexes between the top-leve omero-guides project and the invidual sub-projects are shared. This explains why your search return two seemingly identical results. I don't know if it's possible to remove this so that only the search associated with the top-level project would be returned

@pwalczysko
Copy link
Member Author

This explains why your search return two seemingly identical results.

Aha, got you, thanks a lot. Yes, the problem does not occur if I click on the second identical result.
Yes, it would be great if we could remove teh individual sub-project search results could be removed.

@jburel
Copy link
Member

jburel commented Aug 21, 2020

The same holds true for "Edit on GitHub", it does not work with sub-project

@astrojuanlu
Copy link

Hello! I'm Juan Luis, I work as Developer Advocate at Read the Docs and @joshmoore told me today about this issue and #23. Sorry it's being so painful to make it work - I will try to find some time to read what you have tried so far and see if we can help. In the meantime, if anybody wants to drop a summary or a list of problems (either here, in #23, or at https://readthedocs.org/support/), that would be great.

@pwalczysko
Copy link
Member Author

Thank you @astrojuanlu - I think @jburel has an open issue (which I cannot find atm) and the best overview of the options and their limitations we are facing here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants