Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chest rollbacks not working #105

Open
oliverwoodings opened this issue Aug 21, 2011 · 3 comments
Open

Chest rollbacks not working #105

oliverwoodings opened this issue Aug 21, 2011 · 3 comments
Labels
Bug Plugin
Milestone
v1.1.0

Comments

@oliverwoodings
Copy link
Owner

Check it
@ahornerr
Copy link

I know this is an old issue, but the problem still exists.

@Zren
Copy link

Zren commented Jun 16, 2012

Found the reason for the bug.
You're using:

if (!(block instanceof InventoryHolder)) return false;

instead of:

if (!(block.getState() instanceof InventoryHolder)) return false;

https://github.com/Zren/HawkEye/blob/master/src/main/java/uk/co/oliwali/HawkEye/entry/ContainerEntry.java#L40

Zren added a commit to Zren/HawkEye that referenced this issue Jun 16, 2012
@Zren
Fix Issue oliverwoodings#105 where chest transactions's were not roll…
6a94905 
…ing back.

There are no implementation of a Block/InventoryHolder mix. You need to call block.getState() in order to get an object that impements it.
@Zren Zren mentioned this issue Jun 17, 2012
Closed
@Zren
Copy link

Zren commented Jun 19, 2012

I've also noticed that any item with a data/damage value will not revert. Which probably means a custom inv.addItem() / .remItem().

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Plugin
Projects
None yet
Milestone
v1.1.0
Development

No branches or pull requests
3 participants
@Zren @oliverwoodings @ahornerr