Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slow command execution when using Telnet on AVC-A10H #321

Open
henrikwidlund opened this issue Jan 25, 2025 · 0 comments · May be fixed by #322
Open

Slow command execution when using Telnet on AVC-A10H #321

henrikwidlund opened this issue Jan 25, 2025 · 0 comments · May be fixed by #322

Comments

@henrikwidlund
Copy link

henrikwidlund commented Jan 25, 2025

I've noticed that whenever I execute a command that doesn't use skip_confirmation=True each command takes 3 seconds. Using HTTP doesn't have this problem, and I'm wondering what the best approach to fix this would be (I'd like to provide a PR to fix it).

I've been thinking of two solutions:

  1. Property skip_confirmation in DenonAVRTelnetApi with default value False
  2. Expose the skip_confirmation flag on all commands with default value False
  3. Expose flag to force use HTTP even when Telnet is available

Option 1 is probably easiest to use, but doesn't give any granular control, and might cause issues with the existing overload on the send command methods. Option 3 feels unintuitive.

henrikwidlund added a commit to henrikwidlund/denonavr that referenced this issue Jan 25, 2025
henrikwidlund added a commit to henrikwidlund/denonavr that referenced this issue Jan 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant