Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove appVersion null condition #9900

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

remove appVersion null condition #9900

wants to merge 1 commit into from

Conversation

mnshrm
Copy link
Contributor

@mnshrm mnshrm commented Jan 11, 2025 •
edited by coderabbitai bot
Loading

Removed appVersion equals null Condition in checkForUpdate method in Updatable.tsx

Reason

During software update process for user, we click Check For Update button on profile page, internally we call checkForUpdate method twice, once from UserSoftwareUpdate component and second time from UpdatableApp component, during the first call there is no key app-version in local storage, so app goes inside (appVersion === null) and sets app-version in local storage to latest software version and because of this during the second run inside checkForUpdate method, first if statement is skipped because appVersion exists and second if statement is also skipped because appVersion is equal to latest version and method then does not return, as a result newVersion state in UpdatableApp is assigned to undefined, and we do not get expected pop up

@ohcnetwork/care-fe-code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

Summary by CodeRabbit

  • Bug Fixes
    • Refined version checking mechanism to improve update detection logic
    • Updated application version tracking to prevent unnecessary version overwrites

@mnshrm mnshrm requested a review from a team as a code owner January 11, 2025 10:04
@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 11, 2025 •
edited
Loading

Walkthrough

The pull request modifies the checkForUpdate function in the UpdatableApp component, specifically altering the version checking logic. The changes remove the previous behavior of automatically setting the application version in local storage when it was not found. Now, the function will only check if the current version differs from the fetched version, potentially changing how version updates are detected and handled.

Changes

File Change Summary
src/components/Common/UpdatableApp.tsx Modified checkForUpdate function logic for version checking

Assessment against linked issues

Objective Addressed Explanation
Fix "Check for updates not working" [#9872] ❓ Unable to definitively confirm if the update checking mechanism is fully resolved without additional context

Suggested reviewers

  • rithviknishad

Poem

🐰 A version check, a subtle dance,
Code tweaked with a rabbit's glance,
Local storage, no longer naive,
Updates now wait to perceive,
A digital hop of pure romance! 🔄

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 1dc6138 and 3cd2c5e.

📒 Files selected for processing (1)
  • src/components/Common/UpdatableApp.tsx (0 hunks)
💤 Files with no reviewable changes (1)
  • src/components/Common/UpdatableApp.tsx
⏰ Context from checks skipped due to timeout of 90000ms (3)
  • GitHub Check: OSSAR-Scan
  • GitHub Check: CodeQL-Build
  • GitHub Check: cypress-run (1)

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@netlify Netlify
Copy link

netlify bot commented Jan 11, 2025 •
edited
Loading

✅ Deploy Preview for care-ohc ready!

Name Link
🔨 Latest commit 3cd2c5e
🔍 Latest deploy log https://app.netlify.com/sites/care-ohc/deploys/678242492d23a0000881cf9b
😎 Deploy Preview https://deploy-preview-9900--care-ohc.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Check for updates not working
1 participant
@mnshrm