Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bookmark Icon Not Functioning Correctly for Important Notifications #9305

Closed
Jeffrin2005 opened this issue Dec 5, 2024 · 7 comments
Closed
Assignees

Comments

@Jeffrin2005
Copy link
Contributor

Describe the bug

Starred icon is visible but non-functional.
When clicking the bookmark icon to tag an important notification, it redirects to the "Log Update" section instead of marking the notification.

To Reproduce

Steps to reproduce the behavior:

  1. Go to 'Notification Tab'
  2. Click on the bookmark icon
  3. Observe that it does not mark the notification as important and navigates to another page instead

Expected behavior

The bookmark icon should be marked in red when a notification is tagged as important.

Record Clip

Bookmarking.mp4

Desktop (please complete the following information):

  • OS: [e.g. iOS]
  • Browser [e.g. chrome, safari]
  • Version [e.g. 22]
@Jeffrin2005
Copy link
Contributor Author

@rithviknishad @Jacobjeevan I would like to work on this. Could you please assign it to me?

@github-actions github-actions bot added needs-triage question Further information is requested labels Dec 5, 2024
@Jacobjeevan
Copy link
Contributor

That's not a bookmark icon, but rather patient log update icon (speaking of which, we might have to update the icon there 🤔 ).

As such, clicking on it should take to patient log update page - consultation/consultation:id/log_updates/log:id/critical_care. You can navigate it to by visiting a patient consultation page (click on any patient with consultation) and checking the log updates tab for events (and click on view details).

Image

@Jacobjeevan Jacobjeevan removed question Further information is requested needs-triage labels Dec 5, 2024
@Jacobjeevan Jacobjeevan added this to Care Dec 5, 2024
@github-project-automation github-project-automation bot moved this to Triage in Care Dec 5, 2024
@Jacobjeevan Jacobjeevan moved this from Triage to Up Next in Care Dec 5, 2024
@Jeffrin2005
Copy link
Contributor Author

@Jacobjeevan

Changes Made

  • Once the User clicks the Bookmark icon it turned out to Red
  • For persisting the State, used local Storage.
bookmark.mp4

@Jeffrin2005
Copy link
Contributor Author

@Jacobjeevan Please let me know if any further changes are required before PR.

@Jacobjeevan
Copy link
Contributor

@Jacobjeevan

Changes Made

* Once the User clicks the Bookmark icon it turned out to Red

* For persisting the State, used local Storage.

👇

That's not a bookmark icon, but rather patient log update icon (speaking of which, we might have to update the icon there 🤔 ).

As such, clicking on it should take to patient log update page - consultation/consultation:id/log_updates/log:id/critical_care. You can navigate it to by visiting a patient consultation page (click on any patient with consultation) and checking the log updates tab for events (and click on view details).

Image

@Jeffrin2005
Copy link
Contributor Author

@Jacobjeevan
Sorry for the misunderstanding. For confirmation, after clicking the "log update" icon, it should navigate to this page, right? But when we click the log update icon for each person in notifications tab, how do we know which person's details it corresponds to?

Image

@Jacobjeevan
Copy link
Contributor

Jacobjeevan commented Dec 9, 2024

@Jacobjeevan Sorry for the misunderstanding. For confirmation, after clicking the "log update" icon, it should navigate to this page, right? But when we click the log update icon for each person in notifications tab, how do we know which person's details it corresponds to?

No, it should navigate to the log updates detail page; clicking on the view details button (check the screenshot I attached above) takes you to the relevant page.

I looked into it, and it's a BE issue; the URL is technically accurate, however the log update Id stored and retrieved from BE is incorrect. I went ahead and opened a Backend PR to address it.

@Jacobjeevan Jacobjeevan added Backend and removed question Further information is requested needs-triage labels Dec 9, 2024
@Jacobjeevan Jacobjeevan moved this from Up Next to Review required in Care Dec 9, 2024
@github-actions github-actions bot added the stale label Dec 24, 2024
@rithviknishad rithviknishad closed this as not planned Won't fix, can't repro, duplicate, stale Dec 31, 2024
@github-project-automation github-project-automation bot moved this from Review required to Done in Care Dec 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

No branches or pull requests

3 participants