-
Notifications
You must be signed in to change notification settings - Fork 516
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bookmark Icon Not Functioning Correctly for Important Notifications #9305
Comments
@rithviknishad @Jacobjeevan I would like to work on this. Could you please assign it to me? |
That's not a bookmark icon, but rather patient log update icon (speaking of which, we might have to update the icon there 🤔 ). As such, clicking on it should take to patient log update page - consultation/consultation:id/log_updates/log:id/critical_care. You can navigate it to by visiting a patient consultation page (click on any patient with consultation) and checking the log updates tab for events (and click on view details). |
Changes Made
bookmark.mp4 |
@Jacobjeevan Please let me know if any further changes are required before PR. |
👇
|
@Jacobjeevan |
No, it should navigate to the log updates detail page; clicking on the view details button (check the screenshot I attached above) takes you to the relevant page. I looked into it, and it's a BE issue; the URL is technically accurate, however the log update Id stored and retrieved from BE is incorrect. I went ahead and opened a Backend PR to address it. |
Describe the bug
Starred icon is visible but non-functional.
When clicking the bookmark icon to tag an important notification, it redirects to the "Log Update" section instead of marking the notification.
To Reproduce
Steps to reproduce the behavior:
Expected behavior
The bookmark icon should be marked in red when a notification is tagged as important.
Record Clip
Bookmarking.mp4
Desktop (please complete the following information):
The text was updated successfully, but these errors were encountered: