Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Minimum quantity data in the inventory list page #6612

Closed
nihal467 opened this issue Nov 15, 2023 · 12 comments
Closed

Add Minimum quantity data in the inventory list page #6612

nihal467 opened this issue Nov 15, 2023 · 12 comments

Comments

@nihal467
Copy link
Member

Describe the bug
Follow-up : #2549

Currently, without going to the minimum required section, we can't understand what is the minimum quantity required for the item, which is not a good user experience

To Reproduce
Steps to reproduce the behavior:

  1. Go to facility inventory management page and add a item
  2. See error

Expected behavior

On the right side on a inventory item quantity , we should be displaying the minimum quantity required

Screenshots

image

@github-project-automation github-project-automation bot moved this to Triage in Care Nov 15, 2023
@rithviknishad rithviknishad moved this from Triage to Up Next in Care Nov 15, 2023
@rithviknishad rithviknishad added the good first issue Good for newcomers label Nov 15, 2023
@vasudevravula
Copy link

Hi @nihal467 @rithviknishad
Looked into this a bit, we need to do a getMinInventory call that is being done when the Minimum Quantity Required button is clicked to add this new column.

Also, there are two min_quantity fields in the payload, that is not so intutitve, one I assume is a default value and the other is the value set
image

@vasudevravula
Copy link

let me know if you are okay with adding this min_quantity call during the page load, I can add this

@rithviknishad
Copy link
Member

Yup! That should be fine for now.

@vasudevravula
Copy link

Can you assign this to me, I can start working on this

@vasudevravula
Copy link

@rithviknishad @nihal467 I have taken a deeper look into this, and I can confirm that this needs to be fixed on the API side by adding a new property (ex: configuredMinQuantity) to the inventorysummery response that gives the minimum quantity required for each item.
Reason: The invertorysummery API response and the min_quantity API response are both paginated. When the min_quantity list grows bigger there will be a scenario where all the items from invertorysummery might not get their corresponding min_quantity from the min_quantity list, which will lead to displaying the incorrect min quantity on the UI.

As API is already returning an is_low indicator, this shouldn't be a big change on the API side, once that is added, we can come back and fix this on the UI

@vasudevravula
Copy link

I'm happy to make this change on the API side and then come back and fix this. If you're okay with it, please create an issue on the API repo and assign it to me and link this issue there

@vasudevravula
Copy link

vasudevravula commented Nov 20, 2023

@rithviknishad any thoughts on this?

@rithviknishad
Copy link
Member

@vasudevravula issue has been created. ohcnetwork/care#1721

Copy link

github-actions bot commented Dec 8, 2023

Hi, @gigincg, @nihal467, @khavinshankar, @mathew-alex, @aparnacoronasafe, This issue has been automatically marked as stale because it has not had any recent activity.

@balaji-sivasakthi
Copy link

@nihal467 I would like to work on this issue.

@Thanush19
Copy link

Hey, if the issue is not completed, I can work on this.

@rithviknishad
Copy link
Member

rithviknishad commented Mar 8, 2024

A rework of the entire inventory management is happening in ohcnetwork/docs#38

cc: @khavinshankar

@rithviknishad rithviknishad closed this as not planned Won't fix, can't repro, duplicate, stale Mar 8, 2024
@github-project-automation github-project-automation bot moved this from Up Next to Done in Care Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

5 participants