Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retry on Failure #114

Open
InteXX opened this issue Oct 4, 2020 · 2 comments
Open

Retry on Failure #114

InteXX opened this issue Oct 4, 2020 · 2 comments

Comments

@InteXX
Copy link
Contributor

InteXX commented Oct 4, 2020

Is there a way to retry if the process fails for any reason?

I encountered this error:

[09/01/2020 00:01:37 > dd0b6d: INFO] Error during Request or install certificate System.Exception: Unable to complete challenge with Lets Encrypt servers error was: {"type":"http-01","url":"https://acme-v02.api.letsencrypt.org/acme/chall-v3/6903145984/zVwXJQ","status":"Invalid","validated":null,"error":{"Type":"urn:ietf:params:acme:error:dns","Detail":"During secondary validation: No valid IP addresses found for [Redacted]","Identifier":null,"Subproblems":null,"Status":400},"errors":null,"token":"[Redacted]","keyAuthorization":null}

This appears to have been a transient network problem that likely would not have repeated on a second run. Indeed, I ran the job manually just now and it completed easily and successfully.

Would you consider integrating Polly for implementing a retry policy? I'd send a PR myself, but I'm not very handy with C#.

@ohadschn
Copy link
Owner

ohadschn commented Oct 4, 2020

Good idea, I've been running into transient failures as well, will do when I get the time.

@InteXX
Copy link
Contributor Author

InteXX commented Oct 4, 2020

If your time is anything like mine, it's going to be hard to find ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants