Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Empty cells rule #1

Open
picks44 opened this issue Nov 24, 2021 · 1 comment
Open

Empty cells rule #1

picks44 opened this issue Nov 24, 2021 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@picks44
Copy link

picks44 commented Nov 24, 2021

Hello,

Thanks a million for this wonderful tool. I've been looking for this for years, and it is so time-saving...

Just one enhancement that would be appreciated: if we add a new translation key in the Excel file, then all columns (except English for instance) are empty (until they get translated by agencies).
When converting to JSON, then the key value is set to null.
This strategy is preventing our app fallback strategy from working, meaning that if I switch my app to FR for instance, then the value displayed is also "null".

Could you add an option to the command in order to remove the key woth empty values from the JSON? This would allow the fallback strategy to work properly. Make it an option in case other projects needs to have the null value :)

What do you think?

@ofcyln ofcyln self-assigned this Jun 21, 2022
@ofcyln ofcyln added the enhancement New feature or request label Jun 21, 2022
@ofcyln
Copy link
Owner

ofcyln commented Jun 21, 2022

Hello,

I'm glad this tool made you save time.
Your suggestion is accurate, instead of unsemantic null words for untranslated or new fields, there could be an option to bypass those labels or even keep them as empty fields (as long as JS let us do that).
I'll work on this improvement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants