Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Kueue service backend #709

Draft
wants to merge 46 commits into
base: main
Choose a base branch
from
Draft

Conversation

cortadocodes
Copy link
Member

@cortadocodes cortadocodes commented Jan 9, 2025

Contents (#709)

IMPORTANT: There is 1 breaking change.

New features

  • Add octue question ask CLI command
  • Add ability to ask remote question from CLI
  • Add octue question events raw command
  • Add octue question events replay CLI command

Enhancements

  • Deserialise octue question ask inputs from JSON
  • Add async option to octue question ask
  • Deprecate octue run command
  • Support parsing already-extracted questions
  • Remove unnecessary log message
  • Improve description of commands
  • Suppress google crc32c warning
  • Improve description of octue question ask local
  • Move get-diagnostics command to octue question diagnostics
  • Allow passing of attributes to octue question ask local
  • 💥 BREAKING CHANGE: Allow setting of Octue services topic name via envvar
  • Log when question event extraction is complete

Fixes

  • Fix incorrect type
  • Return question UUID for async octue question ask
  • Fix event and attributes generation
  • Add missing kwarg
  • Fix argument name and backend format in CLI command
  • Fix --asynchronous option in command
  • Fix setting attributes for question event
  • Return data from octue question ask remote properly
  • Await publishing of result event
  • Return early for async question in octue question ask remote
  • Avoid assuming question is a dict
  • Fix typo in OCTUE_SERVICES_TOPIC_NAME envvar
  • Remove non-existent service revision check for now
  • Add missing elif
  • Convert attributes to correct types in make_attributes
  • Extract attributes correctly from passed-in format

Operations

  • Increase minor version number
  • Correct version number

Dependencies

  • Temporarily remove numpy and pandas dev dependencies
  • Drop support for python 3.8 and 3.9
  • Add numpy and pandas back to dev dependencies
  • Update lock file

Refactoring

  • Split octue question ask into ask and ask-local commands
  • Rename answer_question to answer_pub_sub_question
  • Move ask* subcommands under octue question ask group
  • Rename octue question events raw to octue question events get

Testing

  • Update test for python3.13
  • Update mock paths
  • Fix test for different python versions

Style

  • Add missing ruff isort pre-commit check

Upgrade instructions

💥 Allow setting of Octue services topic name via envvar

Update the services topic in production to be named main.octue.services or set the environment variable OCTUE_SERVICES_TOPIC_NAME=octue.services

@cortadocodes cortadocodes linked an issue Jan 13, 2025 that may be closed by this pull request
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Run questions via CLI without starting a service
1 participant