Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RList.make_from_s cannot be used within update step #10

Open
mfp opened this issue Oct 15, 2015 · 2 comments
Open

RList.make_from_s cannot be used within update step #10

mfp opened this issue Oct 15, 2015 · 2 comments

Comments

@mfp
Copy link

mfp commented Oct 15, 2015

make_from_s uses React.S.value, which can raise a Failure when executed within an update step. I haven't been able to define it using only React non-primitive operators. Even though coping out to a concurrency monad does work, it's not desirable here since it'd introduce a new dependency (and force the user's hand in deciding between Lwt/async/other).

Similarly, all the imperative operations on the handle are unsafe within an update step -- this should at least be documented.

@pveber
Copy link
Contributor

pveber commented Jan 18, 2018

I just hit the same issue (the function is now named RList.from_signal). IMHO this is a serious issue, since it basically prevents in eliom to define a reactive element that creates reactive parts itself.

@balat
Copy link
Member

balat commented Jan 25, 2018

@hhugo Do you have an idea about this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants