You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I haven't looked at the code for this project, so I have no idea if this is actually a problem from this repo, or is actually an issue in the image-spec repo source, as I'm not sure if the raw link back to image-spec is intended (and it's just the commitish that is wrong) or if there's a missing feature to ensure that the markdown image-embed URL is relative (or absolutised) to the build-artifact URL.
I had a quick look at the underlying HTML, and it looks like the image reference is relative (same as the markdown), which won't work for the build artifacts as they do not have the img folder. The HTML also has a base element in the header, and that is the place where the incorrect commitish appears. So the simple fix would be to fix the base element, but then there's no particular value in having the images in this repo if the image references point back to the image-spec repo anyway.
The text was updated successfully, but these errors were encountered:
I just had a quick look at https://oci-playground.github.io/specs-latest/specs/image/ceeb2eba078e8b630f5ee62df2e92323fb521f0e/oci-image-spec.html, and the first embedded image is https://raw.githubusercontent.com/opencontainers/image-spec/1.1.0-rc.5+dev/img/build-diagram.png which doesn't exist. The actual image build artifact is https://oci-playground.github.io/specs-latest/specs/image/ceeb2eba078e8b630f5ee62df2e92323fb521f0e/build-diagram.png, and the correct raw link is https://raw.githubusercontent.com/opencontainers/image-spec/ceeb2eba078e8b630f5ee62df2e92323fb521f0e/img/build-diagram.png
Similarly, https://oci-playground.github.io/specs-latest/specs/image/v1.1.0-rc5/oci-image-spec.html links to https://raw.githubusercontent.com/opencontainers/image-spec/1.1.0-rc.4/img/build-diagram.png which doesn't exist, the build artifact link is https://oci-playground.github.io/specs-latest/specs/image/v1.1.0-rc5/build-diagram.png and the correct raw link is https://raw.githubusercontent.com/opencontainers/image-spec/v1.1.0-rc5/img/build-diagram.png.
I haven't looked at the code for this project, so I have no idea if this is actually a problem from this repo, or is actually an issue in the image-spec repo source, as I'm not sure if the raw link back to image-spec is intended (and it's just the commitish that is wrong) or if there's a missing feature to ensure that the markdown image-embed URL is relative (or absolutised) to the build-artifact URL.
I had a quick look at the underlying HTML, and it looks like the image reference is relative (same as the markdown), which won't work for the build artifacts as they do not have the
img
folder. The HTML also has abase
element in the header, and that is the place where the incorrect commitish appears. So the simple fix would be to fix thebase
element, but then there's no particular value in having the images in this repo if the image references point back to the image-spec repo anyway.The text was updated successfully, but these errors were encountered: