Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change style / looks #2

Open
marc-portier opened this issue Apr 27, 2022 · 4 comments
Open

change style / looks #2

marc-portier opened this issue Apr 27, 2022 · 4 comments

Comments

@marc-portier
Copy link
Contributor

the merlot theme we are starting with is too different from the generated ro-crate-previews of the subpages

@marc-portier
Copy link
Contributor Author

marc-portier commented May 3, 2022

even the new style applied during meeting 2022-05-03 has some room for improvement

  • should spill over to subsites
  • add an image / icon
  • should bring a recurring header/footer and feel of consistency
  • should link to assemble+ and other...
  • also should link to our vliz-be-opsci space (to be created)

@kmexter
Copy link
Contributor

kmexter commented May 3, 2022

Katrina can add text/content to the footer and a wee bit more blabla to the existing text, and can provide an OSD image.
Just say when and where to do that.

@marc-portier
Copy link
Contributor Author

strategy to introduce some conformity between the subsites and the main one

  1. loading the css --> both could be referring to an agreed /css/main.css
    • this should be provided by this parent-level-side and just included by the child-sites
    • if it is not there - 404 on css will just not load and hopefully the subsite has some internal way for proper default styling
    • note that the top level can still use existing themes and meaningful css names by using a css @import statement
  2. further the subsite could be "inviting" the parent structure to inject header-footer content through that very same css
    • by introducing surrounding <a href="/"><div class="ro-crate-preview-header"></div></a> and <div class="ro-crate-preview-header"></div> snippets
    • these could be just leading to be ignored (visually not taking any space) if no-css or no-content is provided
    • the parent level css can simply inject the content to be displayed through rules like
.ro-crate-preview-header::before {
  content: '';
  background:url('«relative path from css to logo.png provided by parent project»') 
} 
.ro-crate-preview-header::after {
  content: "«name of the project»"
} 

@marc-portier
Copy link
Contributor Author

please let us focus at least on some quick wins:

  • align top level style with subsites (both full width, same fonts, ..)
  • make the navigaytion integrated --> at least have a link back from the subsites to the top level

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants