Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporary store to property #1

Open
Swaagie opened this issue Mar 4, 2015 · 1 comment
Open

Temporary store to property #1

Swaagie opened this issue Mar 4, 2015 · 1 comment

Comments

@Swaagie
Copy link
Member

Swaagie commented Mar 4, 2015

Temporary store the to property in Redis so account creation for instance can be deferred until after validation of the email/sms or similar. This property should also be returned as third argument in the validate callback.

@3rd-Eden
Copy link
Member

3rd-Eden commented Mar 4, 2015

So what i'm suggesting here is to completely remove the id requirement which only made sense when you create accounts before login and start storing all the data that is passed in the login method: https://github.com/observing/tolkien#tolkienlogin in dynamis directly so when we do https://github.com/observing/tolkien#tolkienvalidate we can merge this stored data with the third argument.

Removing the id also clean ups the code a bit further as we can just nuke the part where store the id->token relations https://github.com/observing/tolkien/blob/master/index.js#L151-L156

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants