-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
switch branching_part_of use in the vasculature to connecting branch of #3088
Comments
These are the blood vessels that are branching_part_of another blood vessel: https://api.triplydb.com/s/ISg2WL4YA |
This is the list of terms. The column connected to indicates that the object property needs to be changed. The column Other indicates if AS does not have the object property or if it has multiple and one needs to be removed. |
I guess this table just has the subject terms? I think it would be easier to automate this if we have a table of triples (subject , relation, object) that need to be changed. It should be easy to do this via UberGraph queries.
This can easily be turned into a robot template or used as source for a SPARQL update to remove the old relations. |
@anitacaron we need a query like this SELECT * WHERE {
?subject_vessel rdfs:subClassOf vessel: .
?object_vessel rdfs:subClassOf vessel: .
?subject_vessel branching_part_of: ?object_vessel .
?subject_vessel rdfs:label ?s_label .
?subject_vessel rdfs:label ?o_label .
} But where the first 2 clauses query the redundant graph the 3rd queries the non-redundant graph and the last two the ontology. (Might also work if the only the third is restricted to nonredundant) |
As there are some grouping classes of branches 'branch of ...' , making
|
The safest way to identify what's already in the ontology would be to have this clause run on the ontology graph: ?subject_vessel branching_part_of: ?object_vessel . as this will identify OWL axioms you need to target. @anitacaron should be able to help you write SPARQL that deals with blank nodes. |
Update uberon-editor-sop.md file accordingly |
Addresses #3088 change vascular object property
So far I have:
However, we also want to create a pattern for vasculature. @dosumis would it be on the scope of this ticket? |
I think so. Go for it. |
…nch_of Addresses #3088 change vascular object property
branching_part_of is a subproperty of part_of, so use of it leads to distantly connected parts of the vasculature appearing to be parts of each other. the replacement is a subroperty of connected_to, so does not cause this problem
TBC: change the name of connecting_branch_of in RO to branches_from?
The text was updated successfully, but these errors were encountered: