Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QueryPublisher unsubscribes after one event #86

Open
1 task done
Feuerwerk opened this issue Sep 18, 2024 · 2 comments
Open
1 task done

QueryPublisher unsubscribes after one event #86

Feuerwerk opened this issue Sep 18, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@Feuerwerk
Copy link

Is there an existing issue?

Build info

  • ObjectBox version: 4.0.0

Steps to reproduce

let query: Query<Person> = ......
query.publisher
                    .replaceError(with: [])
                    /*.assign(to: \.persons, on: viewModel)*/
                    .sink(receiveValue: { persons in
                        viewModel.persons = persons
                    })
                    .store(in: &cancellables)

Expected behavior

I expected that viewModel.persons will update continuously when I add / change a record that will match my query.

Actual behavior

After the initial query result is consumed by the Subscriber, QueryPublisher will unsubscribe because various Subscriber implementations like sink(), assign(to:) or onReceive() of a SwiftUI view will return Subscriber.Demand.none which causes QueryPublisher to signal completion to the Subscriber and shut down.

@Feuerwerk Feuerwerk added the bug Something isn't working label Sep 18, 2024
@kemkriszt
Copy link

I'm also curious of how to handle this, I ended up creating a custom subscriber that after every receive requests unlimited but it seems like an ugly hack to me

@greenrobot-team
Copy link
Member

greenrobot-team commented Sep 30, 2024

Thanks for reporting. The current publisher implementation indeed does send the finished event once it receives a none demand (so demand for 0) from the subscriber.

I guess the underlying issue is that it uses Query.subscribe() behind the scenes which does not have a concept for demand. We should probably have a look at improving this, or maybe someone has an idea for an improvement?

And so I think the current workaround is to use the subscribe APIs (like in the example) instead.

(There is also an internal issue to improve SwiftUI support at objectbox/objectbox-swift#134.)

@greenrobot-team greenrobot-team added enhancement New feature or request and removed bug Something isn't working labels Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants