-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
eth_feeHistory not supported #501
Comments
While this is technically possible to implement, one possibility is also to just require the usage of the The reasoning for this is that the gas-price returned by the oasis-web3-gateway is dynamically calculated and it should be a good estimate (see here for details). I believe this should generally return a good gas price value. Also note that the way oasis-sdk handles EIP1559 transactions base-fee is always zero. Can you please comment on how high priority is adding the eth_feeHistory endpoint, or if is using eth_gasPrice an ok short-term solution? As for implementation goes, seems somewhat straightforward with some caveats/simplification:
As per the above seems reasonable limiting to e.g. last 10 blocks.
So the implementation requires:
|
There's an initial implementation in #502 Seems to be working based on the simple unit test. Needs some more testing. Feel free to try it out if you'll have the time. |
The
eth_feeHistory
andeth_maxPriorityFeePerGas
JSON-RPC calls are used by Web3.py when estimating gasThe text was updated successfully, but these errors were encountered: