Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Content no longer fits the popup #213

Open
tjanez opened this issue Jan 6, 2022 · 9 comments
Open

Content no longer fits the popup #213

tjanez opened this issue Jan 6, 2022 · 9 comments
Labels
bug Something isn't working

Comments

@tjanez
Copy link
Member

tjanez commented Jan 6, 2022

When testing version 1.1.0 I noticed that the extension's content no longer fits the "fixed" popup size of the extension.

Here is an example:
Screenshot from 2022-01-06 14-50-47

@tjanez tjanez added the bug Something isn't working label Jan 6, 2022
@lukaw3d lukaw3d added the p:0 Priority: High! bugs, address immediately label Jan 6, 2022
@lukaw3d
Copy link
Member

lukaw3d commented Jan 6, 2022

For reference:

@lukaw3d
Copy link
Member

lukaw3d commented Jan 6, 2022

I haven't been able to reproduce on xorg. Nor wayland

From screenshot it looks like you might be using 125% upscaling. Tried that too 🤷

@pro-wh
Copy link
Contributor

pro-wh commented Jan 6, 2022

hm I'm testing on a 1x dpi monitor

@tjanez
Copy link
Member Author

tjanez commented Jan 6, 2022

Just tried it again with 2 fresh Chromium profiles and couldn't reproduce it anymore...

First try using Wayland:

chromium-browser --enable-features=UseOzonePlatform  --ozone-platform=wayland --user-data-dir=/tmp/Chromium-Dev1/

Initial "detached" popup window:
Wayland - Initial detached popup window - 03 - Account home

"Ordinary" popup:
Wayland - Popup window - Account home

And then without using Wayland:

chromium-browser --user-data-dir=/tmp/Chromium-Dev2/

Initial "detached" popup window:
Non-Wayland - Initial detached popup window - 03 - Account home

"Ordinary" popup:
Non-Wayland - Popup window - Account home

@tjanez
Copy link
Member Author

tjanez commented Jan 6, 2022

I'll close this for now and we can re-open it if we encounter it again.

@tjanez tjanez closed this as completed Jan 6, 2022
@tjanez tjanez removed the p:0 Priority: High! bugs, address immediately label Jan 10, 2022
@tjanez
Copy link
Member Author

tjanez commented Jan 10, 2022

Just hit this again today. It happened when I switched from to a non-HiDPI (and non-scaled) external display:
Screenshot from 2022-01-10 15-23-48

@tjanez tjanez reopened this Jan 10, 2022
@tjanez
Copy link
Member Author

tjanez commented Jan 10, 2022

Moving browser window to the HiDPI (scaled) laptop diplay, everything works correctly:
Screenshot from 2022-01-10 15-33-19

@lukaw3d
Copy link
Member

lukaw3d commented Jan 10, 2022

Curious, does this not happen on Metamask and other extensions too?

@pro-wh
Copy link
Contributor

pro-wh commented Jan 10, 2022

huh, the narrow screenshot wasn't even the old width

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants