Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rewrite async code #160

Open
pro-wh opened this issue Nov 16, 2021 · 1 comment
Open

rewrite async code #160

pro-wh opened this issue Nov 16, 2021 · 1 comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request

Comments

@pro-wh
Copy link
Contributor

pro-wh commented Nov 16, 2021

For our preferred style, we'd like to adjust the style of async code:

  • switch to async/await, avoid lower level new Promise/resolve+reject where possible
  • errors should be thrown/passed to reject where possible, avoid things like return {error: error} or resolve(error); handle them by catching instead of if (result.error)

follows #156
@gparty gparty added documentation Improvements or additions to documentation enhancement New feature or request labels Oct 4, 2022
@pro-wh
Copy link
Contributor Author

pro-wh commented Oct 17, 2022

reexamining issues I opened. this issue remains

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gparty @pro-wh