Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extraneous check? also, naming nit. #5905

Open
bennetyee opened this issue Oct 14, 2024 · 0 comments
Open

extraneous check? also, naming nit. #5905

bennetyee opened this issue Oct 14, 2024 · 0 comments

Comments

@bennetyee
Copy link
Contributor

bennetyee commented Oct 14, 2024

let is_zero_xy = bp.coefficient(i, j).unwrap().is_zero();

is_zero_ij? in any case, what is the rationale for needing this coefficient to be non-zero? if it is actually needed, a comment explaining why would be useful.

same extraneous check here:

if self.vm.element(i, j).unwrap().is_identity().into() {

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant