Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nit: old_ai name is misleading #5858

Open
bennetyee opened this issue Sep 19, 2024 · 0 comments
Open

nit: old_ai name is misleading #5858

bennetyee opened this issue Sep 19, 2024 · 0 comments

Comments

@bennetyee
Copy link
Contributor

if let Some(old_ai) = self.a.get_mut(i) {

rather than old_ai maybe ai_ref or ai_mref for the mutable reference? i don't know what is a more proper rustacean name, but old_ai seems to be referring to the (old) value, and changing it via *old_ai = ai just doesn't read properly to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant