Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the keep_n and keep_last naming #5822

Open
amela opened this issue Aug 22, 2024 · 0 comments
Open

Fix the keep_n and keep_last naming #5822

amela opened this issue Aug 22, 2024 · 0 comments

Comments

@amela
Copy link
Member

amela commented Aug 22, 2024

keep_n is for consensus, and keep_last is for runtimes.

Otherwise, they work exactly the same, just inconsistent naming.

However, we should fix the naming in the future to be consistent.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@amela