Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deploy and Set up quiz in one task #4

Merged
merged 2 commits into from
Jul 29, 2024
Merged

Deploy and Set up quiz in one task #4

merged 2 commits into from
Jul 29, 2024

Conversation

ZigaMr
Copy link
Collaborator

@ZigaMr ZigaMr commented Jul 16, 2024

Updated hardhat.config to include quiz deploy and entire setup in a single task.

@matevz matevz marked this pull request as ready for review July 17, 2024 12:06
matevz
matevz reviewed Jul 17, 2024
View reviewed changes
Copy link
Member

@matevz matevz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you remove 3a389f0 from this PR so it can be cleanly merged to the main branch?

@ZigaMr
Copy link
Collaborator Author

ZigaMr commented Jul 18, 2024

Removed the duplicated commit.

matevz
matevz reviewed Jul 19, 2024
View reviewed changes
backend/hardhat.config.ts Outdated Show resolved Hide resolved
backend/hardhat.config.ts Outdated Show resolved Hide resolved
backend/hardhat.config.ts Outdated Show resolved Hide resolved
backend/hardhat.config.ts Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
matevz
matevz reviewed Jul 24, 2024
View reviewed changes
Copy link
Member

@matevz matevz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor nits, otherwise looks good.

README.md Show resolved Hide resolved
backend/hardhat.config.ts Show resolved Hide resolved
backend/hardhat.config.ts Outdated Show resolved Hide resolved
backend/hardhat.config.ts Outdated Show resolved Hide resolved
matevz
matevz reviewed Jul 25, 2024
View reviewed changes
.gitignore Show resolved Hide resolved
@ZigaMr
Added script to deploy and setup quiz in one task
413f15e 
Remove duplicated code and update markdown

Update hardhat.config.ts with correct camel case notation

Remove duplicated .gitignore files, update README
@ZigaMr ZigaMr merged commit 0c3600f into oasisprotocol:main Jul 29, 2024
1 of 2 checks passed
@ZigaMr ZigaMr deleted the config-update branch July 29, 2024 07:32
@matevz matevz changed the title Config update Deploy and Set up quiz in one task Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matevz matevz matevz approved these changes

Assignees

@ZigaMr ZigaMr

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ZigaMr @matevz