Proposing var Structure #123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@greg-hellings verifying working methodology |
|
I don't know that we need to have this 100%, mostly this is "we agree on the basic structure". I fully expect the actual contents to change as we go. |
jjaswanson4
commented
Jul 30, 2020
Comment on lines
+52
to
+57
| domains: | ||
| - name: example.com | ||
| locations: | ||
| - loc_1 | ||
| organizations: | ||
| - org_1 |
There was a problem hiding this comment.
The org information may be redundant since we're under satellite.organications.org_1, and may lead to undesired behavior by the module in multi-org setups
|
Confirmed that this is the proper way to do PRs. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Combining @flyemsafe's and @jjaswanson4 var structures, proposed for going forward