Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jest config in package.json gets ignored #335

Open
jaredmcdonald opened this issue Dec 9, 2016 · 1 comment
Open

jest config in package.json gets ignored #335

jaredmcdonald opened this issue Dec 9, 2016 · 1 comment

Comments

@jaredmcdonald
Copy link
Contributor

Versions of kyt, node, OS

0.3.x, 6.9.x, OSX Sierra

Bug or Feature?

enhancement/bug

Current Behavior

looking into #329 revealed (I think) that jest config in package.json is getting ignored. this seems a little confusing to ignore the canonical way of configuring Jest

Desired Behavior

our jest config builder should pull the jest config out of the user's package.json, merge that onto the kyt defaults, and then feed it to modifyJestConfig

@tizmagik, thoughts?

@tizmagik
Copy link
Contributor

@jaredmcdonald yea that probably makes sense. Another thing we might need to consider is if users pass in a Jest configuration at the command line, we would need to also take that into account before merging kyt's configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants