Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose acceptsGzip #34

Open
wyattjoh opened this issue Mar 8, 2017 · 2 comments
Open

Expose acceptsGzip #34

wyattjoh opened this issue Mar 8, 2017 · 2 comments

Comments

@wyattjoh
Copy link

wyattjoh commented Mar 8, 2017

I'd like to use this package with my custom web application wrapper, but I can't match the functionality provided by the NewGzipLevelHandler without the acceptsGzip function exposed: https://github.com/NYTimes/gziphandler/blob/fb3533722e14198abe471546c9798fd556531451/gzip.go#L174

@adammck
Copy link
Contributor

adammck commented Mar 8, 2017

I wouldn't be against making acceptsGzip/parseEncodings/parseCoding public, but we should move them to a subpackage if we do so. For the latter two, we might want to consider dropping our impl in favor of gddo/httputil/header.ParseAccept anyway, which would make the former trivial.

@glasser
Copy link

glasser commented Mar 20, 2018

In general it's hard to use the exported GzipResponseWriter directly because of this issue but also because there's no way to set its options from outside the package.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants