Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor method of creating namespaces #28

Open
tonglil opened this issue Apr 13, 2017 · 3 comments
Open

Refactor method of creating namespaces #28

tonglil opened this issue Apr 13, 2017 · 3 comments

Comments

@tonglil
Copy link
Member

tonglil commented Apr 13, 2017

Instead of specifying the namespace in the configuration, that parameter should point to a K8s resource manifest template.

This would make Namespaces follow the same pattern as Secrets (.kube.sec.yml file).

Namespaces could then be created (maybe even updated via kubectl apply -f) with labels from vars:.

This functionality is asked mainly for namespace-deploy-on-pull-requests, which Drone 0.4 is not capable of, but is a functionality Drone 0.5+ is capable of.

@msuterski
Copy link
Contributor

Does it mean if we were running 0.5, this feature would not be needed?

@tonglil
Copy link
Member Author

tonglil commented Apr 19, 2017

@msuterski it means the opposite: this would improve Namespaces (by adding labels to them) for use by deploy on PRs, which can only be done in 0.5+.

@msuterski
Copy link
Contributor

Great. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants