Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

telescope-fzf-native.nvim needs to run make #18

Open
xfactor2000 opened this issue Jul 19, 2024 · 7 comments
Open

telescope-fzf-native.nvim needs to run make #18

xfactor2000 opened this issue Jul 19, 2024 · 7 comments

Comments

@xfactor2000
Copy link

Hello. I was trying to install https://github.com/nvim-telescope/telescope-fzf-native.nvim but hit a dead-end with make command which needs to run first time plugin is initiated. For example, with lazy.nvim it's simple:

{ 'nvim-telescope/telescope-fzf-native.nvim', build = 'make' }

I wasn't able to configure it for rocks.nvim though.

Appreciate your help and keep up the great work!

@mrcjkb
Copy link
Member

mrcjkb commented Jul 19, 2024

Hey 👋

If the plugin is packaged for luarocks, any build steps should be included in the rockspec and you needn't worry about it. Luarocks will take care of building it automatically.
If it isn't working, then there is an issue with the rockspec.

(cc @teto, #11).

As a workaround, if it isn't working, it can be installed using rocks-git.nvim, which has a build option.

@mrcjkb
Copy link
Member

mrcjkb commented Jul 19, 2024

Transferring this issue to NURR.
We either need to add support for custom rockspecs/rockspec templates, or we should PR telescope-fzf-native.nvim.

@mrcjkb mrcjkb transferred this issue from nvim-neorocks/rocks.nvim Jul 19, 2024
@mrcjkb mrcjkb changed the title Running "make" command telescope-fzf-native.nvim needs to run make Jul 19, 2024
@mrcjkb
Copy link
Member

mrcjkb commented Jul 19, 2024

question @teto: Had you tested this?
Does luarocks compile the C sources automatically, using the builtin build backend, or do we need to change it to use the make build backend?

@xfactor2000
Copy link
Author

Hey 👋

If the plugin is packaged for luarocks, any build steps should be included in the rockspec and you needn't worry about it. Luarocks will take care of building it automatically. If it isn't working, then there is an issue with the rockspec.

(cc @teto, #11).

As a workaround, if it isn't working, it can be installed using rocks-git.nvim, which has a build option.

Thank you, will try this. Another workaround is to use fzf-lua. Cheers!

@xfactor2000
Copy link
Author

Hey 👋
If the plugin is packaged for luarocks, any build steps should be included in the rockspec and you needn't worry about it. Luarocks will take care of building it automatically. If it isn't working, then there is an issue with the rockspec.
(cc @teto, #11).
As a workaround, if it isn't working, it can be installed using rocks-git.nvim, which has a build option.

Thank you, will try this. Another workaround is to use fzf-lua. Cheers!

Can confirm it works with rocks-git.nvim

@mrcjkb
Copy link
Member

mrcjkb commented Jul 21, 2024

I just remembered I have an open PR for this:

@mrcjkb
Copy link
Member

mrcjkb commented Jul 21, 2024

Removing telescope-fzf-native from luarocks/NURR, as it is broken. I will await a response to the PR before I add it again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants