Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Input validation is lacking for tag length #4663

Open
nus-pe-bot opened this issue Apr 14, 2023 · 1 comment
Open

Input validation is lacking for tag length #4663

nus-pe-bot opened this issue Apr 14, 2023 · 1 comment

Comments

@nus-pe-bot
Copy link

nus-pe-bot commented Apr 14, 2023

While it was mentioned in the UG that tag length should be less than 30 characters, there is no input validation to check for that, and users are allowed to enter a 40 character tag.

image.png

Also, the proposed solution in DG does not include checks for input length to tag.

image.png


[original: nus-cs2103-AY2223S2/pe-interim#4660] [original labels: severity.Low type.FeatureFlaw]
@runoutofit
Copy link
Contributor

Team's Response

should is only a recommendation, not a requirement. additionally, in the proposed solutions we mentioned addresses, emails and phone numbers as examples for having an enforced limit. this does not mean that we do not believe this should apply to tags.

Duplicate status (if any):

--

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants