Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DG Logic component is not updated from AB3 #6037

Open
nus-pe-bot opened this issue Nov 13, 2020 · 1 comment
Open

DG Logic component is not updated from AB3 #6037

nus-pe-bot opened this issue Nov 13, 2020 · 1 comment

Comments

@nus-pe-bot
Copy link

nus-pe-bot commented Nov 13, 2020

Note from the teaching team: This bug was reported during the Part II (Evaluating Documents) stage of the PE. You may reject this bug if it is not related to the quality of documentation.



The sequence diagram and the explanation for the Logic API is not updated from AB3; the sequence diagram seems to still have the "deletePerson(1)" method which is inappropriate and should probably be deleteContact(1) and the explanation still says "delete 1" whereas the diagram says "deletec 1".

33.PNG

1212.PNG


[original: nus-cs2103-AY2021S1/pe-interim#6036]
@joshualiangxy
Copy link
Contributor

Team's Response

Severity set to very low, as this does not affect usage and is still largely understandable.

deletePerson method still exists and is still in use.

Duplicate of #6036.

Duplicate status (if any):

Duplicate of #6036

@joshualiangxy joshualiangxy added duplicate This issue or pull request already exists severity.VeryLow status.Done and removed severity.Medium labels Nov 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants