Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Able to make a conflicting sorting comparator #4183

Open
nus-pe-bot opened this issue Nov 15, 2019 · 1 comment
Open

Able to make a conflicting sorting comparator #4183

nus-pe-bot opened this issue Nov 15, 2019 · 1 comment

Comments

@nus-pe-bot
Copy link

image.png

Even though the error message here states that fields must be in all upper or all lowercase:

image.png

Note that the userguide doesn't contain much info on this makesort too:

image.png


[original: nus-cs2103-AY1920S1/pe-interim#4205]
@seanlowjk
Copy link
Contributor

seanlowjk commented Nov 16, 2019

Team's Response

Team's Response

Thank you for testing our application.

For the second photo, it seems that you are not sure how makesort works.

However, it was stated in the user guide that tag is an invalid field, with reference to the photo from our user guide below. As a result, the subsequent error message is thrown.

image

Not only that, my team feels that this issue should not be of high severity. It is not a flaw that affects most users and causes major problems for users. i.e., makes the product almost unusable for most users.

Hence, we would have to give it low severity, where it is a flaw that is unlikely to affect normal operations of the product. Appears only in very rare situations and causes a minor inconvenience only. Users will understand from the User Guide that you are not allowed to have tag as a FIELD.

As a result of the reasons given, we would have to reject this issue. Thanks for your bug report!

Duplicate status (if any):

Based on your first photo, you have mentioned it already in #4185 As a result, you can click on the link to see the comments given by my team.

Duplicate status (if any):

--

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants