Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove or overhaul ShowFactors for alpha #452

Open
gwhitney opened this issue Aug 28, 2024 · 3 comments
Open

Remove or overhaul ShowFactors for alpha #452

gwhitney opened this issue Aug 28, 2024 · 3 comments
Labels
question Further information is requested visualizer Has to do with a visualizer or the visualizer subsystem.

Comments

@gwhitney
Copy link
Collaborator

Is this visualizer now obsolete, given the existence of the FactorFence visualizer just checked in? I would be comfortable with deleting it.

If it is to be kept, here are the overhaul items:

Does the visualizer handle/request canvas size/aspect ratio gracefully and appropriately for the new ui?

Is the visualizer pushing as much validation down to the per-parameter checks as possible?

Is it doing the appropriate level of resetting/recomputation in presketch vs setup?

Is it using descriptions, warnings, and errors appropriately, and not changing the user's input out from under their keystrokes? (Note that if a human interaction entails a change in another parameter -- for example, if you were binning terms and there were 10K terms then setting bin size to 10 might change number of bins to 1000, while changing the number of bins to 100 would change the bin size to100 -- that's OK; we just don't want to seem to be ignoring or contradicting their immediate keystrokes; instead, we inform the person what's at issue with what they entered.

Is it sufficiently and appropriately responsive to events and input? Does it handle resizes as gracefully as can be in the current scheme?

In some cases, there are accumulated small previously-existing issues that should be addressed as well.

@gwhitney gwhitney added question Further information is requested visualizer Has to do with a visualizer or the visualizer subsystem. labels Aug 28, 2024
@gwhitney
Copy link
Collaborator Author

I believe plan was to move this to workbench for alpha. It should still get a cursory overhaul. Any objections @katestange @Vectornaut ?

@Vectornaut
Copy link
Collaborator

I'm not familiar with this visualizer, so I'm happy to move it to the workbench.

@katestange
Copy link
Member

agree, workbench is fine

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested visualizer Has to do with a visualizer or the visualizer subsystem.
Projects
None yet
Development

No branches or pull requests

3 participants