Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update console warning comment from pull-request-checklist.md when warning goes away #173

Open
liammulh opened this issue Oct 18, 2022 · 2 comments

Comments

@liammulh
Copy link
Member

From #171 (comment), @katestange noted that there is a comment in the PR checklist doc that says there's a warning about assets. We need to remove this comment when the warning goes away.

@gwhitney
Copy link
Collaborator

This should be resolved in #420.

@gwhitney
Copy link
Collaborator

Hmmm, actually we are up to 2 megabytes for the main chunk of the app, which is pretty huge. So I think this is out of scope for #420 after all, but it may well be related to #454 and so should get the same milestone as that, once a milestone is chosen for #454. Leaving this on alpha for now so we notice and deal with it once the milestone is set for #454.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants