From d8272a4d08f12edcd60f544904a7b0cbd3ce306a Mon Sep 17 00:00:00 2001 From: alishakawaguchi Date: Fri, 26 Jan 2024 15:14:32 -0800 Subject: [PATCH] change frontend run log env var name (#1188) --- frontend/apps/web/app/(mgmt)/[account]/runs/[id]/page.tsx | 2 +- frontend/apps/web/app/api/config/config.ts | 2 +- frontend/apps/web/app/config/app-config.ts | 2 +- frontend/apps/web/charts/app/templates/app-env-vars.yaml | 2 +- frontend/apps/web/charts/app/values.yaml | 3 +-- 5 files changed, 5 insertions(+), 6 deletions(-) diff --git a/frontend/apps/web/app/(mgmt)/[account]/runs/[id]/page.tsx b/frontend/apps/web/app/(mgmt)/[account]/runs/[id]/page.tsx index fc3295af85..26b8591d28 100644 --- a/frontend/apps/web/app/(mgmt)/[account]/runs/[id]/page.tsx +++ b/frontend/apps/web/app/(mgmt)/[account]/runs/[id]/page.tsx @@ -226,7 +226,7 @@ export default function Page({ params }: PageProps): ReactElement { })} {!isSystemAppConfigDataLoading && - systemAppConfigData?.isKubernetes && ( + systemAppConfigData?.enableRunLogs && (
diff --git a/frontend/apps/web/app/api/config/config.ts b/frontend/apps/web/app/api/config/config.ts index 487fd84bb4..b3ca14b659 100644 --- a/frontend/apps/web/app/api/config/config.ts +++ b/frontend/apps/web/app/api/config/config.ts @@ -18,6 +18,6 @@ export function getSystemAppConfig(): SystemAppConfig { key: process.env.POSTHOG_KEY, }, isNeosyncCloud: process.env.NEOSYNC_CLOUD === 'true', - isKubernetes: process.env.KUBERNETES_ENABLED === 'true', + enableRunLogs: process.env.ENABLE_RUN_LOGS === 'true', }; } diff --git a/frontend/apps/web/app/config/app-config.ts b/frontend/apps/web/app/config/app-config.ts index ac3865b467..69dca17dc3 100644 --- a/frontend/apps/web/app/config/app-config.ts +++ b/frontend/apps/web/app/config/app-config.ts @@ -3,7 +3,7 @@ export interface SystemAppConfig { publicAppBaseUrl: string; posthog: PosthogConfig; isNeosyncCloud: boolean; - isKubernetes: boolean; + enableRunLogs: boolean; } interface PosthogConfig { diff --git a/frontend/apps/web/charts/app/templates/app-env-vars.yaml b/frontend/apps/web/charts/app/templates/app-env-vars.yaml index aa62d1b836..6245e2ea26 100644 --- a/frontend/apps/web/charts/app/templates/app-env-vars.yaml +++ b/frontend/apps/web/charts/app/templates/app-env-vars.yaml @@ -82,4 +82,4 @@ stringData: NEOSYNC_CLOUD: {{ .Values.neosyncCloud.enabled | default "false" | quote }} - KUBERNETES_ENABLED: {{ .Values.kubernetes.enabled | default "false" | quote }} + ENABLE_RUN_LOGS: {{ .Values.enableRunLogs | default "false" | quote }} diff --git a/frontend/apps/web/charts/app/values.yaml b/frontend/apps/web/charts/app/values.yaml index d3df66367f..c3c18d9210 100644 --- a/frontend/apps/web/charts/app/values.yaml +++ b/frontend/apps/web/charts/app/values.yaml @@ -66,5 +66,4 @@ nodeSelector: {} neosyncCloud: enabled: false -kubernetes: - enabled: false +enableRunLogs: false