Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FuzzMessageDecode fails sometimes #3316

Closed
AliceInHunterland opened this issue Feb 13, 2024 · 6 comments · Fixed by #3364
Closed

FuzzMessageDecode fails sometimes #3316

AliceInHunterland opened this issue Feb 13, 2024 · 6 comments · Fixed by #3364
Labels
bug Something isn't working I3 Minimal impact S4 Routine test Unit tests U4 Nothing urgent
Milestone
v0.106.0

Comments

@AliceInHunterland
Copy link
Contributor

Run tests (ubuntu-20.04, 1.20) and ubuntu 1.19
5_Run tests.txt
maybe related to #3307 (or caused by).
Just rerunning the failed job helps - for example Run tests (ubuntu-20.04, 1.20) (just successful run).
@AliceInHunterland AliceInHunterland added bug Something isn't working U2 Seriously planned and removed U2 Seriously planned labels Feb 13, 2024
@AliceInHunterland AliceInHunterland mentioned this issue Feb 14, 2024
Merged
@AnnaShaleva
Copy link
Member

Just rerunning the failed job helps

It doesn't help, it just tells that this problem is poorly reproduceable.

maybe related to #3307 (or caused by).

Hardly ever it can be related to the logger sync.

@AnnaShaleva AnnaShaleva added the test Unit tests label Feb 15, 2024
@AnnaShaleva AnnaShaleva added this to the v0.106.0 milestone Feb 15, 2024
@AnnaShaleva AnnaShaleva added I3 Minimal impact U4 Nothing urgent S4 Routine labels Feb 15, 2024
@AliceInHunterland
Copy link
Contributor Author

AliceInHunterland commented Feb 16, 2024 •
edited
Loading

as we had data races in pkg/network tests it seems to me that failing FuzzMessageDecode with race detected during execution of test is just another manifestation of the #3307 problem.
So we had race in the network test package (and fixed it) not in this exact test.

@AnnaShaleva
Copy link
Member

Discussed, and closing this issue as not relevant after #3307.

@AnnaShaleva AnnaShaleva closed this as not planned Won't fix, can't repro, duplicate, stale Mar 11, 2024
@AnnaShaleva AnnaShaleva reopened this Mar 14, 2024
@AnnaShaleva
Copy link
Member

AnnaShaleva commented Mar 14, 2024 •
edited
Loading

Reproduced on fresh 37d4012 (#791, Ubuntu 22.04, https://github.com/nspcc-dev/neo-go/actions/runs/8277371374/job/22647600402?pr=3355), but the real reason is not in FuzzMessageDecode, because race is detected in the other test:

2024-03-14T08:14:03.3871907Z --- PASS: TestServerNotSendsVerack (0.00s)
2024-03-14T08:14:03.3872003Z ==================
2024-03-14T08:14:03.3872100Z WARNING: DATA RACE
2024-03-14T08:14:03.3872322Z Read at 0x00c000203083 by goroutine 198:
2024-03-14T08:14:03.3872461Z   testing.(*common).logDepth()
2024-03-14T08:14:03.3872817Z       /opt/hostedtoolcache/go/1.20.14/x64/src/testing/testing.go:992 +0xc4
2024-03-14T08:14:03.3872939Z   testing.(*common).log()
2024-03-14T08:14:03.3873275Z       /opt/hostedtoolcache/go/1.20.14/x64/src/testing/testing.go:985 +0xa4
2024-03-14T08:14:03.3873395Z   testing.(*common).Logf()
2024-03-14T08:14:03.3873734Z       /opt/hostedtoolcache/go/1.20.14/x64/src/testing/testing.go:1036 +0x6a
2024-03-14T08:14:03.3873843Z   testing.(*T).Logf()
2024-03-14T08:14:03.3873986Z       <autogenerated>:1 +0x75
2024-03-14T08:14:03.3874169Z   go.uber.org/zap/zaptest.TestingWriter.Write()
2024-03-14T08:14:03.3874576Z       /home/runner/go/pkg/mod/go.uber.org/[email protected]/zaptest/logger.go:146 +0x12c
2024-03-14T08:14:03.3874756Z   go.uber.org/zap/zaptest.(*TestingWriter).Write()
2024-03-14T08:14:03.3874893Z       <autogenerated>:1 +0x7e
2024-03-14T08:14:03.3875054Z   go.uber.org/zap/zapcore.(*ioCore).Write()
2024-03-14T08:14:03.3875430Z       /home/runner/go/pkg/mod/go.uber.org/[email protected]/zapcore/core.go:99 +0x199
2024-03-14T08:14:03.3875693Z   go.uber.org/zap/zapcore.(*CheckedEntry).Write()
2024-03-14T08:14:03.3876086Z       /home/runner/go/pkg/mod/go.uber.org/[email protected]/zapcore/entry.go:253 +0x2ce
2024-03-14T08:14:03.3876221Z   go.uber.org/zap.(*Logger).Info()
2024-03-14T08:14:03.3876560Z       /home/runner/go/pkg/mod/go.uber.org/[email protected]/logger.go:247 +0x6a
2024-03-14T08:14:03.3876823Z   github.com/nspcc-dev/neo-go/pkg/network.(*Server).run()
2024-03-14T08:14:03.3877209Z       /home/runner/work/neo-go/neo-go/pkg/network/server.go:497 +0xc54
2024-03-14T08:14:03.3877668Z   github.com/nspcc-dev/neo-go/pkg/network.TestServerNotSendsVerack.func1.1()
2024-03-14T08:14:03.3878081Z       /home/runner/work/neo-go/neo-go/pkg/network/server_test.go:340 +0x39
2024-03-14T08:14:03.3878090Z 
2024-03-14T08:14:03.3878256Z Previous write at 0x00c000203083 by goroutine 196:
2024-03-14T08:14:03.3878385Z   testing.tRunner.func1()
2024-03-14T08:14:03.3878738Z       /opt/hostedtoolcache/go/1.20.14/x64/src/testing/testing.go:1563 +0x82d
2024-03-14T08:14:03.3878860Z   runtime.deferreturn()
2024-03-14T08:14:03.3879185Z       /opt/hostedtoolcache/go/1.20.14/x64/src/runtime/panic.go:476 +0x32
2024-03-14T08:14:03.3879298Z   testing.(*T).Run.func1()
2024-03-14T08:14:03.3879647Z       /opt/hostedtoolcache/go/1.20.14/x64/src/testing/testing.go:1629 +0x47
2024-03-14T08:14:03.3879654Z 
2024-03-14T08:14:03.3879774Z Goroutine 198 (running) created at:
2024-03-14T08:14:03.3880229Z   github.com/nspcc-dev/neo-go/pkg/network.TestServerNotSendsVerack.func1()
2024-03-14T08:14:03.3880632Z       /home/runner/work/neo-go/neo-go/pkg/network/server_test.go:340 +0xa4
2024-03-14T08:14:03.3880638Z 
2024-03-14T08:14:03.3880759Z Goroutine 196 (running) created at:
2024-03-14T08:14:03.3880866Z   testing.(*T).Run()
2024-03-14T08:14:03.3881212Z       /opt/hostedtoolcache/go/1.20.14/x64/src/testing/testing.go:1629 +0x805
2024-03-14T08:14:03.3881339Z   testing.runTests.func1()
2024-03-14T08:14:03.3881673Z       /opt/hostedtoolcache/go/1.20.14/x64/src/testing/testing.go:2036 +0x8d
2024-03-14T08:14:03.3881787Z   testing.tRunner()
2024-03-14T08:14:03.3882126Z       /opt/hostedtoolcache/go/1.20.14/x64/src/testing/testing.go:1576 +0x216
2024-03-14T08:14:03.3882239Z   testing.runTests()
2024-03-14T08:14:03.3882570Z       /opt/hostedtoolcache/go/1.20.14/x64/src/testing/testing.go:2034 +0x87c
2024-03-14T08:14:03.3882673Z   testing.(*M).Run()
2024-03-14T08:14:03.3883009Z       /opt/hostedtoolcache/go/1.20.14/x64/src/testing/testing.go:1906 +0xb44
2024-03-14T08:14:03.3883108Z   main.main()
2024-03-14T08:14:03.3883273Z       _testmain.go:139 +0x2e9
2024-03-14T08:14:03.3883360Z ==================
2024-03-14T08:14:03.3883456Z === RUN   TestBlock

But somehow FuzzMessageDecode also fails with no reason, I think that it's just about the fact that race from previous test is detected during FuzzMessageDecode run.

2024-03-14T08:14:03.4024045Z === NAME  
2024-03-14T08:14:03.4024292Z     testing.go:1446: race detected during execution of test
2024-03-14T08:14:03.4024410Z === RUN   FuzzMessageDecode
2024-03-14T08:14:03.4024531Z === RUN   FuzzMessageDecode/seed#0
2024-03-14T08:14:03.4024652Z === RUN   FuzzMessageDecode/seed#1
2024-03-14T08:14:03.4024764Z === RUN   FuzzMessageDecode/seed#2
2024-03-14T08:14:03.4024876Z === RUN   FuzzMessageDecode/seed#3
2024-03-14T08:14:03.4024994Z === RUN   FuzzMessageDecode/seed#4
2024-03-14T08:14:03.4025105Z === RUN   FuzzMessageDecode/seed#5
2024-03-14T08:14:03.4025222Z === RUN   FuzzMessageDecode/seed#6
2024-03-14T08:14:03.4025332Z === RUN   FuzzMessageDecode/seed#7
2024-03-14T08:14:03.4025512Z === RUN   FuzzMessageDecode/seed#8
2024-03-14T08:14:03.4025625Z === RUN   FuzzMessageDecode/seed#9
2024-03-14T08:14:03.4025740Z === RUN   FuzzMessageDecode/seed#10
2024-03-14T08:14:03.4025858Z === RUN   FuzzMessageDecode/seed#11
2024-03-14T08:14:03.4025971Z === RUN   FuzzMessageDecode/seed#12
2024-03-14T08:14:03.4026089Z === RUN   FuzzMessageDecode/seed#13
2024-03-14T08:14:03.4026202Z === RUN   FuzzMessageDecode/seed#14
2024-03-14T08:14:03.4026316Z === RUN   FuzzMessageDecode/seed#15
2024-03-14T08:14:03.4026435Z === RUN   FuzzMessageDecode/seed#16
2024-03-14T08:14:03.4026548Z === RUN   FuzzMessageDecode/seed#17
2024-03-14T08:14:03.4026671Z === RUN   FuzzMessageDecode/seed#18
2024-03-14T08:14:03.4026781Z === RUN   FuzzMessageDecode/seed#19
2024-03-14T08:14:03.4026900Z === RUN   FuzzMessageDecode/seed#20
2024-03-14T08:14:03.4027011Z === RUN   FuzzMessageDecode/seed#21
2024-03-14T08:14:03.4027122Z === RUN   FuzzMessageDecode/seed#22
2024-03-14T08:14:03.4027242Z === RUN   FuzzMessageDecode/seed#23
2024-03-14T08:14:03.4027355Z === RUN   FuzzMessageDecode/seed#24
2024-03-14T08:14:03.4027474Z === RUN   FuzzMessageDecode/seed#25
2024-03-14T08:14:03.4027586Z === RUN   FuzzMessageDecode/seed#26
2024-03-14T08:14:03.4027696Z === RUN   FuzzMessageDecode/seed#27
2024-03-14T08:14:03.4027814Z === RUN   FuzzMessageDecode/seed#28
2024-03-14T08:14:03.4027924Z === RUN   FuzzMessageDecode/seed#29
2024-03-14T08:14:03.4028230Z === RUN   FuzzMessageDecode/seed#30
2024-03-14T08:14:03.4028364Z === RUN   FuzzMessageDecode/seed#31
2024-03-14T08:14:03.4028494Z === RUN   FuzzMessageDecode/seed#32
2024-03-14T08:14:03.4028609Z === RUN   FuzzMessageDecode/seed#33
2024-03-14T08:14:03.4028720Z === RUN   FuzzMessageDecode/seed#34
2024-03-14T08:14:03.4028839Z === RUN   FuzzMessageDecode/seed#35
2024-03-14T08:14:03.4028949Z === RUN   FuzzMessageDecode/seed#36
2024-03-14T08:14:03.4029070Z === RUN   FuzzMessageDecode/seed#37
2024-03-14T08:14:03.4029185Z === RUN   FuzzMessageDecode/seed#38
2024-03-14T08:14:03.4029299Z === RUN   FuzzMessageDecode/seed#39
2024-03-14T08:14:03.4029417Z === RUN   FuzzMessageDecode/seed#40
2024-03-14T08:14:03.4029531Z === RUN   FuzzMessageDecode/seed#41
2024-03-14T08:14:03.4029650Z === RUN   FuzzMessageDecode/seed#42
2024-03-14T08:14:03.4029762Z === RUN   FuzzMessageDecode/seed#43
2024-03-14T08:14:03.4029872Z === RUN   FuzzMessageDecode/seed#44
2024-03-14T08:14:03.4029991Z === RUN   FuzzMessageDecode/seed#45
2024-03-14T08:14:03.4030106Z === RUN   FuzzMessageDecode/seed#46
2024-03-14T08:14:03.4030310Z === RUN   FuzzMessageDecode/seed#47
2024-03-14T08:14:03.4030427Z === RUN   FuzzMessageDecode/seed#48
2024-03-14T08:14:03.4030546Z === RUN   FuzzMessageDecode/seed#49
2024-03-14T08:14:03.4030658Z === RUN   FuzzMessageDecode/seed#50
2024-03-14T08:14:03.4030770Z === RUN   FuzzMessageDecode/seed#51
2024-03-14T08:14:03.4030889Z === RUN   FuzzMessageDecode/seed#52
2024-03-14T08:14:03.4030999Z === RUN   FuzzMessageDecode/seed#53
2024-03-14T08:14:03.4031123Z === RUN   FuzzMessageDecode/seed#54
2024-03-14T08:14:03.4031236Z === RUN   FuzzMessageDecode/seed#55
2024-03-14T08:14:03.4031347Z === RUN   FuzzMessageDecode/seed#56
2024-03-14T08:14:03.4031533Z === RUN   FuzzMessageDecode/seed#57
2024-03-14T08:14:03.4031647Z === RUN   FuzzMessageDecode/seed#58
2024-03-14T08:14:03.4031764Z === RUN   FuzzMessageDecode/seed#59
2024-03-14T08:14:03.4031875Z === RUN   FuzzMessageDecode/seed#60
2024-03-14T08:14:03.4031993Z === RUN   FuzzMessageDecode/seed#61
2024-03-14T08:14:03.4032106Z === RUN   FuzzMessageDecode/seed#62
2024-03-14T08:14:03.4032218Z === RUN   FuzzMessageDecode/seed#63
2024-03-14T08:14:03.4032335Z === RUN   FuzzMessageDecode/seed#64
2024-03-14T08:14:03.4032446Z === RUN   FuzzMessageDecode/seed#65
2024-03-14T08:14:03.4032563Z === RUN   FuzzMessageDecode/seed#66
2024-03-14T08:14:03.4032673Z === RUN   FuzzMessageDecode/seed#67
2024-03-14T08:14:03.4032785Z === RUN   FuzzMessageDecode/seed#68
2024-03-14T08:14:03.4032904Z === RUN   FuzzMessageDecode/seed#69
2024-03-14T08:14:03.4033016Z === RUN   FuzzMessageDecode/seed#70
2024-03-14T08:14:03.4033209Z === RUN   FuzzMessageDecode/seed#71
2024-03-14T08:14:03.4033322Z === RUN   FuzzMessageDecode/seed#72
2024-03-14T08:14:03.4033438Z === RUN   FuzzMessageDecode/seed#73
2024-03-14T08:14:03.4033548Z === RUN   FuzzMessageDecode/seed#74
2024-03-14T08:14:03.4033659Z === RUN   FuzzMessageDecode/seed#75
2024-03-14T08:14:03.4033775Z === RUN   FuzzMessageDecode/seed#76
2024-03-14T08:14:03.4033887Z === RUN   FuzzMessageDecode/seed#77
2024-03-14T08:14:03.4034003Z === RUN   FuzzMessageDecode/seed#78
2024-03-14T08:14:03.4034116Z === RUN   FuzzMessageDecode/seed#79
2024-03-14T08:14:03.4034228Z === RUN   FuzzMessageDecode/seed#80
2024-03-14T08:14:03.4034345Z === RUN   FuzzMessageDecode/seed#81
2024-03-14T08:14:03.4034457Z === RUN   FuzzMessageDecode/seed#82
2024-03-14T08:14:03.4034573Z === RUN   FuzzMessageDecode/seed#83
2024-03-14T08:14:03.4034686Z === RUN   FuzzMessageDecode/seed#84
2024-03-14T08:14:03.4034802Z === RUN   FuzzMessageDecode/seed#85
2024-03-14T08:14:03.4034916Z === RUN   FuzzMessageDecode/seed#86
2024-03-14T08:14:03.4035026Z === RUN   FuzzMessageDecode/seed#87
2024-03-14T08:14:03.4035145Z === RUN   FuzzMessageDecode/seed#88
2024-03-14T08:14:03.4035255Z === RUN   FuzzMessageDecode/seed#89
2024-03-14T08:14:03.4035372Z === RUN   FuzzMessageDecode/seed#90
2024-03-14T08:14:03.4035483Z === RUN   FuzzMessageDecode/seed#91
2024-03-14T08:14:03.4035594Z === RUN   FuzzMessageDecode/seed#92
2024-03-14T08:14:03.4035787Z === RUN   FuzzMessageDecode/seed#93
2024-03-14T08:14:03.4035935Z === RUN   FuzzMessageDecode/seed#94
2024-03-14T08:14:03.4036055Z === RUN   FuzzMessageDecode/seed#95
2024-03-14T08:14:03.4036167Z === RUN   FuzzMessageDecode/seed#96
2024-03-14T08:14:03.4036283Z === RUN   FuzzMessageDecode/seed#97
2024-03-14T08:14:03.4036394Z === RUN   FuzzMessageDecode/seed#98
2024-03-14T08:14:03.4036505Z === RUN   FuzzMessageDecode/seed#99
2024-03-14T08:14:03.4036674Z --- FAIL: FuzzMessageDecode (0.01s)
2024-03-14T08:14:03.4036906Z     --- PASS: FuzzMessageDecode/seed#0 (0.00s)
2024-03-14T08:14:03.4037134Z     --- PASS: FuzzMessageDecode/seed#1 (0.00s)
2024-03-14T08:14:03.4037344Z     --- PASS: FuzzMessageDecode/seed#2 (0.00s)
2024-03-14T08:14:03.4037553Z     --- PASS: FuzzMessageDecode/seed#3 (0.00s)
2024-03-14T08:14:03.4037765Z     --- PASS: FuzzMessageDecode/seed#4 (0.00s)
2024-03-14T08:14:03.4037968Z     --- PASS: FuzzMessageDecode/seed#5 (0.00s)
2024-03-14T08:14:03.4038177Z     --- PASS: FuzzMessageDecode/seed#6 (0.00s)
2024-03-14T08:14:03.4038382Z     --- PASS: FuzzMessageDecode/seed#7 (0.00s)
2024-03-14T08:14:03.4038660Z     --- PASS: FuzzMessageDecode/seed#8 (0.00s)
2024-03-14T08:14:03.4038862Z     --- PASS: FuzzMessageDecode/seed#9 (0.00s)
2024-03-14T08:14:03.4039077Z     --- PASS: FuzzMessageDecode/seed#10 (0.00s)
2024-03-14T08:14:03.4039294Z     --- PASS: FuzzMessageDecode/seed#11 (0.00s)
2024-03-14T08:14:03.4039506Z     --- PASS: FuzzMessageDecode/seed#12 (0.00s)
2024-03-14T08:14:03.4039719Z     --- PASS: FuzzMessageDecode/seed#13 (0.00s)
2024-03-14T08:14:03.4039927Z     --- PASS: FuzzMessageDecode/seed#14 (0.00s)
2024-03-14T08:14:03.4040132Z     --- PASS: FuzzMessageDecode/seed#15 (0.00s)
2024-03-14T08:14:03.4040402Z     --- PASS: FuzzMessageDecode/seed#16 (0.00s)
2024-03-14T08:14:03.4040612Z     --- PASS: FuzzMessageDecode/seed#17 (0.00s)
2024-03-14T08:14:03.4040822Z     --- PASS: FuzzMessageDecode/seed#18 (0.00s)
2024-03-14T08:14:03.4041025Z     --- PASS: FuzzMessageDecode/seed#19 (0.00s)
2024-03-14T08:14:03.4041238Z     --- PASS: FuzzMessageDecode/seed#20 (0.00s)
2024-03-14T08:14:03.4041445Z     --- PASS: FuzzMessageDecode/seed#21 (0.00s)
2024-03-14T08:14:03.4041650Z     --- PASS: FuzzMessageDecode/seed#22 (0.00s)
2024-03-14T08:14:03.4041861Z     --- PASS: FuzzMessageDecode/seed#23 (0.00s)
2024-03-14T08:14:03.4042063Z     --- PASS: FuzzMessageDecode/seed#24 (0.00s)
2024-03-14T08:14:03.4042272Z     --- PASS: FuzzMessageDecode/seed#25 (0.00s)
2024-03-14T08:14:03.4042473Z     --- PASS: FuzzMessageDecode/seed#26 (0.00s)
2024-03-14T08:14:03.4042681Z     --- PASS: FuzzMessageDecode/seed#27 (0.00s)
2024-03-14T08:14:03.4042946Z     --- PASS: FuzzMessageDecode/seed#28 (0.00s)
2024-03-14T08:14:03.4043152Z     --- PASS: FuzzMessageDecode/seed#29 (0.00s)
2024-03-14T08:14:03.4043359Z     --- PASS: FuzzMessageDecode/seed#30 (0.00s)
2024-03-14T08:14:03.4043563Z     --- PASS: FuzzMessageDecode/seed#31 (0.00s)
2024-03-14T08:14:03.4043775Z     --- PASS: FuzzMessageDecode/seed#32 (0.00s)
2024-03-14T08:14:03.4043981Z     --- PASS: FuzzMessageDecode/seed#33 (0.00s)
2024-03-14T08:14:03.4044185Z     --- PASS: FuzzMessageDecode/seed#34 (0.00s)
2024-03-14T08:14:03.4044396Z     --- PASS: FuzzMessageDecode/seed#35 (0.00s)
2024-03-14T08:14:03.4044598Z     --- PASS: FuzzMessageDecode/seed#36 (0.00s)
2024-03-14T08:14:03.4044809Z     --- PASS: FuzzMessageDecode/seed#37 (0.00s)
2024-03-14T08:14:03.4045012Z     --- PASS: FuzzMessageDecode/seed#38 (0.00s)
2024-03-14T08:14:03.4045220Z     --- PASS: FuzzMessageDecode/seed#39 (0.00s)
2024-03-14T08:14:03.4045421Z     --- PASS: FuzzMessageDecode/seed#40 (0.00s)
2024-03-14T08:14:03.4045630Z     --- PASS: FuzzMessageDecode/seed#41 (0.00s)
2024-03-14T08:14:03.4045848Z     --- PASS: FuzzMessageDecode/seed#42 (0.00s)
2024-03-14T08:14:03.4046057Z     --- PASS: FuzzMessageDecode/seed#43 (0.00s)
2024-03-14T08:14:03.4046266Z     --- PASS: FuzzMessageDecode/seed#44 (0.00s)
2024-03-14T08:14:03.4046471Z     --- PASS: FuzzMessageDecode/seed#45 (0.00s)
2024-03-14T08:14:03.4046686Z     --- PASS: FuzzMessageDecode/seed#46 (0.00s)
2024-03-14T08:14:03.4046952Z     --- PASS: FuzzMessageDecode/seed#47 (0.00s)
2024-03-14T08:14:03.4047174Z     --- PASS: FuzzMessageDecode/seed#48 (0.00s)
2024-03-14T08:14:03.4047392Z     --- PASS: FuzzMessageDecode/seed#49 (0.00s)
2024-03-14T08:14:03.4047600Z     --- PASS: FuzzMessageDecode/seed#50 (0.00s)
2024-03-14T08:14:03.4047812Z     --- PASS: FuzzMessageDecode/seed#51 (0.00s)
2024-03-14T08:14:03.4048018Z     --- PASS: FuzzMessageDecode/seed#52 (0.00s)
2024-03-14T08:14:03.4048221Z     --- PASS: FuzzMessageDecode/seed#53 (0.00s)
2024-03-14T08:14:03.4048431Z     --- PASS: FuzzMessageDecode/seed#54 (0.00s)
2024-03-14T08:14:03.4048635Z     --- PASS: FuzzMessageDecode/seed#55 (0.00s)
2024-03-14T08:14:03.4048846Z     --- PASS: FuzzMessageDecode/seed#56 (0.00s)
2024-03-14T08:14:03.4049050Z     --- PASS: FuzzMessageDecode/seed#57 (0.00s)
2024-03-14T08:14:03.4049257Z     --- PASS: FuzzMessageDecode/seed#58 (0.00s)
2024-03-14T08:14:03.4049459Z     --- PASS: FuzzMessageDecode/seed#59 (0.00s)
2024-03-14T08:14:03.4049664Z     --- PASS: FuzzMessageDecode/seed#60 (0.00s)
2024-03-14T08:14:03.4049936Z     --- PASS: FuzzMessageDecode/seed#61 (0.00s)
2024-03-14T08:14:03.4050140Z     --- PASS: FuzzMessageDecode/seed#62 (0.00s)
2024-03-14T08:14:03.4050350Z     --- PASS: FuzzMessageDecode/seed#63 (0.00s)
2024-03-14T08:14:03.4050552Z     --- PASS: FuzzMessageDecode/seed#64 (0.00s)
2024-03-14T08:14:03.4050767Z     --- PASS: FuzzMessageDecode/seed#65 (0.00s)
2024-03-14T08:14:03.4050970Z     --- PASS: FuzzMessageDecode/seed#66 (0.00s)
2024-03-14T08:14:03.4051172Z     --- PASS: FuzzMessageDecode/seed#67 (0.00s)
2024-03-14T08:14:03.4051385Z     --- PASS: FuzzMessageDecode/seed#68 (0.00s)
2024-03-14T08:14:03.4051647Z     --- PASS: FuzzMessageDecode/seed#69 (0.00s)
2024-03-14T08:14:03.4051861Z     --- PASS: FuzzMessageDecode/seed#70 (0.00s)
2024-03-14T08:14:03.4052064Z     --- PASS: FuzzMessageDecode/seed#71 (0.00s)
2024-03-14T08:14:03.4052267Z     --- PASS: FuzzMessageDecode/seed#72 (0.00s)
2024-03-14T08:14:03.4052478Z     --- PASS: FuzzMessageDecode/seed#73 (0.00s)
2024-03-14T08:14:03.4052683Z     --- PASS: FuzzMessageDecode/seed#74 (0.00s)
2024-03-14T08:14:03.4052895Z     --- PASS: FuzzMessageDecode/seed#75 (0.00s)
2024-03-14T08:14:03.4053100Z     --- PASS: FuzzMessageDecode/seed#76 (0.00s)
2024-03-14T08:14:03.4053310Z     --- PASS: FuzzMessageDecode/seed#77 (0.00s)
2024-03-14T08:14:03.4053512Z     --- PASS: FuzzMessageDecode/seed#78 (0.00s)
2024-03-14T08:14:03.4053714Z     --- PASS: FuzzMessageDecode/seed#79 (0.00s)
2024-03-14T08:14:03.4053926Z     --- PASS: FuzzMessageDecode/seed#80 (0.00s)
2024-03-14T08:14:03.4054192Z     --- PASS: FuzzMessageDecode/seed#81 (0.00s)
2024-03-14T08:14:03.4054407Z     --- PASS: FuzzMessageDecode/seed#82 (0.00s)
2024-03-14T08:14:03.4054610Z     --- PASS: FuzzMessageDecode/seed#83 (0.00s)
2024-03-14T08:14:03.4054818Z     --- PASS: FuzzMessageDecode/seed#84 (0.00s)
2024-03-14T08:14:03.4055024Z     --- PASS: FuzzMessageDecode/seed#85 (0.00s)
2024-03-14T08:14:03.4055227Z     --- PASS: FuzzMessageDecode/seed#86 (0.00s)
2024-03-14T08:14:03.4055438Z     --- PASS: FuzzMessageDecode/seed#87 (0.00s)
2024-03-14T08:14:03.4055645Z     --- PASS: FuzzMessageDecode/seed#88 (0.00s)
2024-03-14T08:14:03.4055854Z     --- PASS: FuzzMessageDecode/seed#89 (0.00s)
2024-03-14T08:14:03.4056057Z     --- PASS: FuzzMessageDecode/seed#90 (0.00s)
2024-03-14T08:14:03.4056262Z     --- PASS: FuzzMessageDecode/seed#91 (0.00s)
2024-03-14T08:14:03.4056471Z     --- PASS: FuzzMessageDecode/seed#92 (0.00s)
2024-03-14T08:14:03.4056674Z     --- PASS: FuzzMessageDecode/seed#93 (0.00s)
2024-03-14T08:14:03.4056894Z     --- PASS: FuzzMessageDecode/seed#94 (0.00s)
2024-03-14T08:14:03.4057097Z     --- PASS: FuzzMessageDecode/seed#95 (0.00s)
2024-03-14T08:14:03.4057307Z     --- PASS: FuzzMessageDecode/seed#96 (0.00s)
2024-03-14T08:14:03.4057510Z     --- PASS: FuzzMessageDecode/seed#97 (0.00s)
2024-03-14T08:14:03.4057716Z     --- PASS: FuzzMessageDecode/seed#98 (0.00s)
2024-03-14T08:14:03.4057924Z     --- PASS: FuzzMessageDecode/seed#99 (0.00s)
2024-03-14T08:14:03.4058079Z FAIL
2024-03-14T08:14:03.4058314Z FAIL	github.com/nspcc-dev/neo-go/pkg/network	3.793s

Full logs:
fuzz.log

@roman-khimov
Copy link
Member

I thought fuzzers are disabled in our regular runs.

@AnnaShaleva
Copy link
Member

AnnaShaleva commented Mar 14, 2024 •
edited
Loading

I thought fuzzers are disabled in our regular runs.

Fuzz tests are run much like a unit test by default. Each seed corpus entry will be tested against the fuzz target, reporting any failures before exiting.

It's just about the fact that seed corpus of this test is quite large. But we run our tests without --fuzz flag, so no fuzzing is performed. Ref. https://go.dev/doc/security/fuzz/.

AliceInHunterland added a commit that referenced this issue Mar 19, 2024
@AliceInHunterland
network: fix logging data race in the package
d6efed0 
Nested goroutines could cause logging race.

Close #3316

Signed-off-by: Ekaterina Pavlova <[email protected]>
@AliceInHunterland AliceInHunterland mentioned this issue Mar 19, 2024
Merged
AliceInHunterland added a commit that referenced this issue Mar 20, 2024
@AliceInHunterland
network: fix logging data race in the package
31548dc 
Nested goroutines could cause logging race.

Close #3316

Signed-off-by: Ekaterina Pavlova <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working I3 Minimal impact S4 Routine test Unit tests U4 Nothing urgent
Projects
None yet
Milestone
v0.106.0
Development

Successfully merging a pull request may close this issue.

network: fix logging data race in the package nspcc-dev/neo-go
3 participants
@roman-khimov @AnnaShaleva @AliceInHunterland