Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UILabel's don't respect incasing view #33

Open
codyrobb opened this issue Aug 6, 2015 · 7 comments
Open

UILabel's don't respect incasing view #33

codyrobb opened this issue Aug 6, 2015 · 7 comments

Comments

@codyrobb
Copy link

codyrobb commented Aug 6, 2015

So, I've been using OAStackView as a drop back for iOS8/7 users. Overall, it has been really really good, but I keep running into the same problem with labels.

I will describe the situation, both are nearly identical.

  1. I have two labels vertically stacked. Alignment is OAStackViewAlignmentLeading, distribution is OAStackViewDistributionFill.
  2. This vertical stack view is nested in a horizontal stack view. It goes [icon, verticalLabelStack, arrow]

Now, UIStackView will either truncate the text or break it into multiple lines (if specified to). In both situations OAStackView has the text overflowing.

This is my only big problem with OAStackView, would be awesome to get this fixed!

@harlanhaskins
Copy link
Contributor

Can you post a screenshot?

@harlanhaskins
Copy link
Contributor

With the UIStackView behavior and OAStackView behavior?

@codyrobb
Copy link
Author

codyrobb commented Aug 6, 2015

UIStackView (iOS 9)

simulator screen shot aug 6 2015 1 43 11 pm


OAStackView (iOS 8.4 & iOS 9)

ios simulator screen shot aug 6 2015 1 45 40 pm


I also double checked OAStackView running on iOS9 to make sure it wasn't an iOS8 issue.

In this case I want the label to truncate, but it continues past the edge. I have also come across a similar problem where I allow the label to grow to multiple lines instead of truncating. UIStackView is able to handle this case, but I'm running into the same problem with OAStackView.

@codyrobb
Copy link
Author

codyrobb commented Aug 6, 2015

I just realized the title of this issue isn't the best description, but I'm not sure what to call it. Feel free to do something about that. 😂

@fabb
Copy link

fabb commented Oct 5, 2015

Have you found a solution for the issue?

@delebedev
Copy link
Collaborator

sorry @fabb, not yet. I'm going to work on this as a first thing soon

@fabb
Copy link

fabb commented Oct 6, 2015

I ended up using TZStackView which works as expected.
https://github.com/tomvanzummeren/TZStackView

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants