Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ios7 compatibility #100

Open
paleozogt opened this issue Jan 19, 2017 · 2 comments
Open

ios7 compatibility #100

paleozogt opened this issue Jan 19, 2017 · 2 comments

Comments

@paleozogt
Copy link
Contributor

PR #87 breaks the ability to have OAStackView be a static framework (because it uses Swift), and consequently breaks iOS 7 compatibility.

OAStackView's own Examples project (Deployment Target = 7.1) is broken because of this:

ld: embedded dylibs/frameworks are only supported on iOS 8.0 and later (@rpath/OAStackView.framework/OAStackView) for architecture armv7

It can't be worked around, either, as Cocoapods doesn't can't support static frameworks with Swift. For example if we remove use_frameworks! from the Podfile we get

[!] Pods written in Swift can only be integrated as frameworks; add `use_frameworks!` to your Podfile or target to opt into using it. The Swift Pod being used is: OAStackView

What problem is OAStackViewProxy.swift trying to solve? PR #60 solves the backwards compatibility problem with objc_allocateClassPair.

paleozogt added a commit to paleozogt/OAStackView that referenced this issue Jan 19, 2017
paleozogt added a commit to paleozogt/OAStackView that referenced this issue Jan 20, 2017
paleozogt added a commit to paleozogt/OAStackView that referenced this issue Jan 20, 2017
@paleozogt
Copy link
Contributor Author

While PR #60 lets you use UIStackView in IB files, what I think PR #87 is after is to let you use OAStackViewProxy in IB files and have it inherit from the right thing (OAStackView or UIStackView, depending on the OS).

There's a simpler way to get at this functionality. We can just have OAStackViewProxy inherit from UIStackView. Since PR #60 makes UIStackView inherit from OAStackView on pre-IOS7, this will work out.

@UInt2048
Copy link

UInt2048 commented Feb 2, 2021

I imagine this is no longer an issue with #101 merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants