Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix commit ref for integration tests workflow #870

Merged
merged 3 commits into from
Nov 5, 2024
Merged

Conversation

chuckwondo
Copy link
Collaborator

@chuckwondo chuckwondo commented Nov 5, 2024

Pull Request (PR) draft checklist - click to expand
  • Please review our
    contributing documentation
    before getting started.
  • Populate a descriptive title. For example, instead of "Updated README.md", use a
    title such as "Add testing details to the contributor section of the README".
    Example PRs: #763
  • Populate the body of the pull request with:
  • Update CHANGELOG.md with details about your change in a section titled
    ## Unreleased. If such a section does not exist, please create one. Follow
    Common Changelog for your additions.
    Example PRs: #763
  • Update the documentation and/or the README.md with details of changes to the
    earthaccess interface, if any. Consider new environment variables, function names,
    decorators, etc.

Click the "Ready for review" button at the bottom of the "Conversation" tab in GitHub
once these requirements are fulfilled. Don't worry if you see any test failures in
GitHub at this point!

Pull Request (PR) merge checklist - click to expand

Please do your best to complete these requirements! If you need help with any of these
requirements, you can ping the @nsidc/earthaccess-support team in a comment and we
will help you out!

  • Add unit tests for any new features.
  • Apply formatting and linting autofixes. You can add a GitHub comment in this Pull
    Request containing "pre-commit.ci autofix" to automate this.
  • Ensure all automated PR checks (seen at the bottom of the "conversation" tab) pass.
  • Get at least one approving review.

📚 Documentation preview 📚: https://earthaccess--870.org.readthedocs.build/en/870/

Copy link

github-actions bot commented Nov 5, 2024

Binder 👈 Launch a binder notebook on this branch for commit a501b5b

I will automatically update this comment whenever this PR is modified

Binder 👈 Launch a binder notebook on this branch for commit d1ac252

Binder 👈 Launch a binder notebook on this branch for commit 34e1624

@chuckwondo
Copy link
Collaborator Author

Ok, integration tests now pass for pull_request, but fail for pull_request_target, but that's okay, because pull_request_target is not using the correct commit. Once this lands, I think this should do the trick, including preventing both pull_request and pull_request_target events attempting to run int. tests.

Only pull_request will run int. tests when PR is from another branch in this repo, and pull_request_target will run int. tests when PR is from a fork.

jhkennedy
jhkennedy previously approved these changes Nov 5, 2024
Copy link
Collaborator

@jhkennedy jhkennedy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! One minor take-it-or-leave-it comment on the if conditional is all.

.github/workflows/integration-test.yml Outdated Show resolved Hide resolved
@chuckwondo
Copy link
Collaborator Author

Thanks guys. I pulled in your suggestion @jhkennedy, so one of you will need to approve again.

@chuckwondo chuckwondo merged commit 926b67b into main Nov 5, 2024
9 of 14 checks passed
@chuckwondo chuckwondo deleted the fix-ref-int-tests branch November 6, 2024 00:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants