Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Does not work with the new Amazon client APIs #6

Open
mcamou opened this issue Feb 15, 2014 · 1 comment
Open

Does not work with the new Amazon client APIs #6

mcamou opened this issue Feb 15, 2014 · 1 comment

Comments

@mcamou
Copy link

mcamou commented Feb 15, 2014

I am using the latest Amazon SDK for Java which uses the new subdomain-based API instead of the resource path API. Sinatra-s3 doesn't work that way. I've forked your repository and fixed it, however I'm not sure everything works correctly since I am testing only for the use cases we need at the moment and haven't updated the tests. Would you like a pull request?
@nricciar
Copy link
Owner

Pull requests are always appreciated. Might take me a little while though to review and import any changes depending on how complicated though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mcamou @nricciar