Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create automated release via GH Action which requires approvals #66

Open
2 tasks
dtzar opened this issue Sep 22, 2022 · 5 comments
Open
2 tasks

Create automated release via GH Action which requires approvals #66

dtzar opened this issue Sep 22, 2022 · 5 comments
Labels
enhancement New feature or request
Milestone

Comments

@dtzar
Copy link
Contributor

dtzar commented Sep 22, 2022

The desire is to have notation, notation-go, and notation-core-go be released in an automated fashion which also requires two approver maintainers for official releases (not dev builds on notation).

Today we release notation via a GitHub workflow with go-releaser, but notation-go and notation-core-go are released manually.

I propose that we utilize GitHub environment approval gates for the actual releases. If this is agreeable, then we would need the following work to implement:

  • Utilize a GitHub Action workflow for releasing notation-go and notation-core-go
  • Convert the release workflows for all three libraries to utilize environment plus approvers
@dtzar dtzar added the enhancement New feature or request label Sep 22, 2022
@dtzar dtzar added this to the RC-1 milestone Sep 22, 2022
@dtzar
Copy link
Contributor Author

dtzar commented Sep 22, 2022

@gokarnm - FYI since you requested.

@iamsamirzon
Copy link
Contributor

Thanks @dtzar for proposing this. LGTM
cc: @vaninrao10

@vaninrao10
Copy link

Can this be moved to RC-2 ?

@dtzar
Copy link
Contributor Author

dtzar commented Nov 3, 2022

Fine by me/MSFT - it was requested in RC-1 by Milind.

@yizha1
Copy link
Contributor

yizha1 commented Nov 9, 2022

Confirmed to move this issue out of rc-1 scope. Now moved to "Discuss". We will review all the issues later for rc-2 release scope.

@yizha1 yizha1 modified the milestones: RC-1, Discuss Nov 9, 2022
@vaninrao10 vaninrao10 modified the milestones: Discuss, future Nov 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Todo
Development

No branches or pull requests

4 participants