From 859354b43383e57de2f72a2429cbadc2062134e7 Mon Sep 17 00:00:00 2001 From: Patrick Ogenstad Date: Mon, 1 Jul 2024 09:11:11 +0200 Subject: [PATCH] Remove obsolete noqa statements (#944) --- nornir/core/__init__.py | 2 +- nornir/core/configuration.py | 2 +- nornir/core/exceptions.py | 2 +- pyproject.toml | 1 - 4 files changed, 3 insertions(+), 4 deletions(-) diff --git a/nornir/core/__init__.py b/nornir/core/__init__.py index 4146f3d8..56a056d0 100644 --- a/nornir/core/__init__.py +++ b/nornir/core/__init__.py @@ -144,7 +144,7 @@ def run( raise_on_error = ( raise_on_error if raise_on_error is not None else self.config.core.raise_on_error - ) # noqa + ) if raise_on_error: result.raise_on_error() else: diff --git a/nornir/core/configuration.py b/nornir/core/configuration.py index 357d9b30..9705345e 100644 --- a/nornir/core/configuration.py +++ b/nornir/core/configuration.py @@ -149,7 +149,7 @@ def configure(self) -> None: "This can lead to unexpected logging results. " "Please set logging.enabled config to False " "to disable automatic Nornir logging configuration. Refer to " - "https://nornir.readthedocs.io/en/stable/configuration/index.html#logging" # noqa + "https://nornir.readthedocs.io/en/stable/configuration/index.html#logging" ) warnings.warn(msg, ConflictingConfigurationWarning) diff --git a/nornir/core/exceptions.py b/nornir/core/exceptions.py index 01599bb1..5a20e87d 100644 --- a/nornir/core/exceptions.py +++ b/nornir/core/exceptions.py @@ -2,7 +2,7 @@ if TYPE_CHECKING: from nornir.core.connection import Connection - from nornir.core.result import AggregatedResult, MultiResult, Result # noqa + from nornir.core.result import AggregatedResult, MultiResult, Result from nornir.core.tasks import Task diff --git a/pyproject.toml b/pyproject.toml index a57b6014..13000aaa 100644 --- a/pyproject.toml +++ b/pyproject.toml @@ -157,7 +157,6 @@ ignore = [ "RSE102", # Unnecessary parentheses on raised exception "RUF001", # String contains ambiguous `–` (EN DASH). Did you mean `-` (HYPHEN-MINUS)? "RUF012", # Mutable class attributes should be annotated with `typing.ClassVar` - "RUF100", # Unused blanket `noqa` directive "S701", # By default, jinja2 sets `autoescape` to `False`. Consider using `autoescape=True` or the `select_autoescape` function to mitigate XSS vulnerabilities. "SLF001", # Private member accessed "SIM108", # Use ternary operator `config = Config.from_file(config_file, **kwargs) if config_file else Config.from_dict(**kwargs)` instead of `if`-`else`-block