Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

exception thrown in constraint #187

Open
joeel1 opened this issue Feb 26, 2016 · 3 comments
Open

exception thrown in constraint #187

joeel1 opened this issue Feb 26, 2016 · 3 comments
Labels

Comments

@joeel1
Copy link

joeel1 commented Feb 26, 2016

just noticed, error happend during constraint's runtime evalution will crash nools, and no being handle by error callback, supplied through 'session.match'.

use case:
i) normal constraint - name: Fact name.valid_param == "some value";
-> matched normally
ii) constraint with undefined/null parameters- name: Fact name. == "some value";
-> matched normally
iii) constraint with undefined property of undefined object: Fact name[undefined parameter][undefined child] == "some value";
-> nools crash....

any idea?.

@DevSide
Copy link
Collaborator

DevSide commented Oct 3, 2016

Yes, you can't use two levels of undefined keys. You can define new facts to represent intermediate data.

@joeel1
Copy link
Author

joeel1 commented Apr 27, 2017

we are interested on taking over nools, in case no one else interested on maintaining the project.
how shall we proceed?

@doug-martin
Copy link
Contributor

Hi @joeel1 I have moved the nools codebase to a new org noolsjs. I am actively working on an update to nools with the first order of business being updating the code base to es6 and to support the latest versions of node. I plan on publishing the new release in a couple of weeks once I have all the documentation updated.

Once I finish the first update I will begin working on getting the outstanding PRs merged then Ill start working on new features. If you are interested in contributing please feel free to issue PRs against this branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants